Implement BroadcastChannel

third_party/WebKit/Source/bindings/core/v8/V8Binding.h

 /*
 * Copyright (C) 2009 Google Inc. All rights reserved.
 * Copyright (C) 2012 Ericsson AB. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
@@ skipping 65 matching lines @@
     STATIC_ONLY(V8TypeOf);
     // |Type| provides C++ -> V8 type conversion for DOM wrappers.
     // The Blink binding code generator will generate specialized version of
     // V8TypeOf for each wrapper class.
     typedef void Type;
 };
 
 // Helpers for throwing JavaScript TypeErrors for arity mismatches.
 CORE_EXPORT void setArityTypeError(ExceptionState&, const char* valid, unsigned provided);
 CORE_EXPORT v8::Local<v8::Value> createMinimumArityTypeErrorForMethod(v8::Isolate*, const char* method, const char* type, unsigned expected, unsigned provided);
-v8::Local<v8::Value> createMinimumArityTypeErrorForConstructor(v8::Isolate*, const char* type, unsigned expected, unsigned provided);
+CORE_EXPORT v8::Local<v8::Value> createMinimumArityTypeErrorForConstructor(v8::Isolate*, const char* type, unsigned expected, unsigned provided);

[kinuko, 2016/06/09 09:14:58]

is this related? (wasn't very obvious to me...)

[Marijn Kruisselbrink, 2016/06/22 18:46:56]

The bindings generated code for a constructor can end up calling this method.
Which if the code is in modules/ requires the method to be exported. So yes,
this is/was related. But another CL in the mean time already added this missing
CORE_EXPORT so it's no longer part of this CL.

 CORE_EXPORT void setMinimumArityTypeError(ExceptionState&, unsigned expected, unsigned provided);
 
 template<typename CallbackInfo, typename S>
 inline void v8SetReturnValue(const CallbackInfo& info, const v8::Persistent<S>& handle)
 {
     info.GetReturnValue().Set(handle);
 }
 
 template<typename CallbackInfo, typename S>
 inline void v8SetReturnValue(const CallbackInfo& info, const v8::Local<S> handle)
@@ skipping 866 matching lines @@
 typedef void (*InstallTemplateFunction)(v8::Isolate*, const DOMWrapperWorld&, v8::Local<v8::FunctionTemplate> interfaceTemplate);
 
 // Freeze a V8 object. The type of the first parameter and the return value is
 // intentionally v8::Value so that this function can wrap toV8().
 // If the argument isn't an object, this will crash.
 CORE_EXPORT v8::Local<v8::Value> freezeV8Object(v8::Local<v8::Value>, v8::Isolate*);
 
 } // namespace blink
 
 #endif // V8Binding_h