Add drawer with state information

Now we can use drawer to view the state information of the native app, and set its state using the spinner.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002

Committed: https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec

Committed: https://skia.googlesource.com/skia/+/e5a6cd9832eaa7011dee162283ff6470f82a3fdc

[liyuqian, 2016-05-20 21:39:55]

Description was changed from

==========
Try Drawer

BUG=skia:
==========

to

==========
Try Drawer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
==========

[liyuqian, 2016-05-24 15:15:58]

Description was changed from

==========
Try Drawer

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
==========

to

==========
Now we can use drawer to view the state information of the native app, and set
its state using the spinner.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
==========

[liyuqian, 2016-05-24 15:15:58]

liyuqian@google.com changed reviewers:
+ djsollen@google.com, jvanverth@google.com

[liyuqian, 2016-05-24 15:21:49]

Now we have a navigation drawer that displays the slide list, and allows you to
directly select a slide :)

[djsollen, 2016-05-24 17:32:40]

https://codereview.chromium.org/2004633002/diff/40001/platform_tools/android/...
File platform_tools/android/apps/viewer/build.gradle (right):

https://codereview.chromium.org/2004633002/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/build.gradle:10: compile
'com.android.support:support-v13:23.3.0'
does this add more requirements for things people must download from the SDK to
run the app?

https://codereview.chromium.org/2004633002/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/build.gradle:15: compileSdkVersion 23
why do we need to update these versions?

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
File tools/viewer/sk_app/Window.h (right):

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
tools/viewer/sk_app/Window.h:30: virtual void onStateUpdated(const char*
stateJsonStr) {}  // do nothing in default
the public API should be consistent with the one in viewer.h so I propose you
use (const Json::Value& state) as your param

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
tools/viewer/sk_app/Window.h:114: typedef void(*OnSetFunc)(const SkString&
stateName, const SkString& stateValue, void* userData);
I find this naming very confusing as both the user and the app can cause changes
to the state.  I think we need a clearer way to distinguish between the two
interactions that indicates this better than onStateUpdated (for app triggered)
and onSet (for user triggered).   Any ideas on the naming?

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.cpp:252: message.stateName =
new SkString(nameChars);
stateName.reset(nameChars);

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.h (right):

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:40: SkString* stateName;
don't store pointers just store an SkString

[liyuqian, 2016-05-24 20:18:05]

Revised according to the comments except the name issue. We'll discuss the name
later.

https://codereview.chromium.org/2004633002/diff/40001/platform_tools/android/...
File platform_tools/android/apps/viewer/build.gradle (right):

https://codereview.chromium.org/2004633002/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/build.gradle:10: compile
'com.android.support:support-v13:23.3.0'
On 2016/05/24 17:32:40, djsollen wrote:
> does this add more requirements for things people must download from the SDK
to
> run the app?

I successfully ran android_make Viewer_APK --vulkan using the SDK we gave to
borenet@, so I guess that nothing more needs to be downloaded?

https://codereview.chromium.org/2004633002/diff/40001/platform_tools/android/...
platform_tools/android/apps/viewer/build.gradle:15: compileSdkVersion 23
On 2016/05/24 17:32:40, djsollen wrote:
> why do we need to update these versions?

Done. Now only compileSdkVersion is 23, others are back to 19.

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
File tools/viewer/sk_app/Window.h (right):

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
tools/viewer/sk_app/Window.h:30: virtual void onStateUpdated(const char*
stateJsonStr) {}  // do nothing in default
On 2016/05/24 17:32:40, djsollen wrote:
> the public API should be consistent with the one in viewer.h so I propose you
> use (const Json::Value& state) as your param

Done.

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
tools/viewer/sk_app/Window.h:114: typedef void(*OnSetFunc)(const SkString&
stateName, const SkString& stateValue, void* userData);
On 2016/05/24 17:32:40, djsollen wrote:
> I find this naming very confusing as both the user and the app can cause
changes
> to the state.  I think we need a clearer way to distinguish between the two
> interactions that indicates this better than onStateUpdated (for app
triggered)
> and onSet (for user triggered).   Any ideas on the naming?

Let's discuss.

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.cpp (right):

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.cpp:252: message.stateName =
new SkString(nameChars);
On 2016/05/24 17:32:40, djsollen wrote:
> stateName.reset(nameChars);

We'll preserve the pointers because of the message pipes.

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/and...
File tools/viewer/sk_app/android/surface_glue_android.h (right):

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/and...
tools/viewer/sk_app/android/surface_glue_android.h:40: SkString* stateName;
On 2016/05/24 17:32:40, djsollen wrote:
> don't store pointers just store an SkString

We'll preserve the pointers because of the message pipes.

[liyuqian, 2016-05-26 15:05:16]

The API names have been changed to setUIState and onUIStateChanged.

[djsollen, 2016-05-26 18:08:40]

lgtm with nits

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
File tools/viewer/sk_app/Window.h (right):

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
tools/viewer/sk_app/Window.h:30: virtual void onStateUpdated(const char*
stateJsonStr) {}  // do nothing in default
On 2016/05/24 17:32:40, djsollen wrote:
> the public API should be consistent with the one in viewer.h so I propose you
> use (const Json::Value& state) as your param

should this be called setState()?

https://codereview.chromium.org/2004633002/diff/40001/tools/viewer/sk_app/Win...
tools/viewer/sk_app/Window.h:151: void onSet(const SkString& stateName, const
SkString& stateValue);
onStateChange()

https://codereview.chromium.org/2004633002/diff/120001/tools/viewer/Viewer.cpp
File tools/viewer/Viewer.cpp (right):

https://codereview.chromium.org/2004633002/diff/120001/tools/viewer/Viewer.cp...
tools/viewer/Viewer.cpp:255: this->fWindow->setUIState(computeUIStateJson());
just call a private updateUIState() function that internally computes it and
notifies the window.

https://codereview.chromium.org/2004633002/diff/120001/tools/viewer/Viewer.cp...
tools/viewer/Viewer.cpp:404: Json::Value Viewer::computeUIStateJson() const {
rename to updateUIState

[liyuqian, 2016-05-26 19:24:45]

The CQ bit was checked by liyuqian@google.com

[liyuqian, 2016-05-26 19:24:45]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/2004633002/#ps140001
(title: "nits")

[commit-bot: I haz the power, 2016-05-26 19:24:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004633002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004633002/140001

[commit-bot: I haz the power, 2016-05-26 19:43:46]

Description was changed from

==========
Now we can use drawer to view the state information of the native app, and set
its state using the spinner.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002
==========

to

==========
Now we can use drawer to view the state information of the native app, and set
its state using the spinner.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002

Committed:
https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec
==========

[commit-bot: I haz the power, 2016-05-26 19:43:48]

Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec

[kjlubick, 2016-05-27 13:12:18]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2017933002/ by kjlubick@google.com.

The reason for reverting is: Broke Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan. 
See
https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubu....

[kjlubick, 2016-05-27 13:21:49]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2016343002/ by kjlubick@google.com.

The reason for reverting is: Broke Build-Ubuntu-GCC-Arm7-Debug-Android_Vulkan. 
See
https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubu....

[liyuqian, 2016-05-27 14:57:41]

Description was changed from

==========
Now we can use drawer to view the state information of the native app, and set
its state using the spinner.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002

Committed:
https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec
==========

to

==========
Now we can use drawer to view the state information of the native app, and set
its state using the spinner.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002

Committed:
https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec
==========

[liyuqian, 2016-05-27 15:35:29]

The CQ bit was checked by liyuqian@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 15:35:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004633002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004633002/160001

[commit-bot: I haz the power, 2016-05-27 15:50:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 15:50:26]

Dry run: This issue passed the CQ dry run.

[liyuqian, 2016-05-27 15:51:48]

The CQ bit was checked by liyuqian@google.com

[liyuqian, 2016-05-27 15:51:49]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com
Link to the patchset: https://codereview.chromium.org/2004633002/#ps160001
(title: "Merge")

[commit-bot: I haz the power, 2016-05-27 15:51:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004633002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004633002/160001

[commit-bot: I haz the power, 2016-05-27 15:52:58]

Description was changed from

==========
Now we can use drawer to view the state information of the native app, and set
its state using the spinner.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002

Committed:
https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec
==========

to

==========
Now we can use drawer to view the state information of the native app, and set
its state using the spinner.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2004633002

Committed:
https://skia.googlesource.com/skia/+/4e4e30823fba0047b93a56bfcf05c04ca57e82ec

Committed:
https://skia.googlesource.com/skia/+/e5a6cd9832eaa7011dee162283ff6470f82a3fdc
==========

[commit-bot: I haz the power, 2016-05-27 15:52:59]

Committed patchset #9 (id:160001) as
https://skia.googlesource.com/skia/+/e5a6cd9832eaa7011dee162283ff6470f82a3fdc