Fix opacity transition of pin keyboard on lockscreen.

Fix opacity transition of pin keyboard on lockscreen.

Before, the opacity would get adjusted before the keyboard had been completely
loaded into the DOM. This patch makes the opacity adjustment wait until after
the pin keyboard has layout information available.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c8e72b2a44ffc2232cf10fcf4463f6c13672d5b8
Cr-Commit-Position: refs/heads/master@{#395359}

[jdufault, 2016-05-20 19:15:18]

Description was changed from

==========
Fix opacity transition of pin keyboard on lockscreen.

Before, the opacity would get adjusted before the keyboard had been completely
loaded into the DOM. This patch makes the opacity adjustment wait until after
the pin keyboard has layout information available.

BUG=603217
==========

to

==========
Fix opacity transition of pin keyboard on lockscreen.

Before, the opacity would get adjusted before the keyboard had been completely
loaded into the DOM. This patch makes the opacity adjustment wait until after
the pin keyboard has layout information available.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[jdufault, 2016-05-20 19:20:11]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org, dzhioev@chromium.org, xiyuan@chromium.org

[jdufault, 2016-05-20 19:20:11]

Pavel, Xiyuan, or Achuith, PTAL. Thanks!

[achuithb, 2016-05-20 19:27:17]

defer to xiyuan

[xiyuan, 2016-05-20 21:06:32]

https://codereview.chromium.org/2004553002/diff/1/ui/login/resource_loader.js
File ui/login/resource_loader.js (right):

https://codereview.chromium.org/2004553002/diff/1/ui/login/resource_loader.js...
ui/login/resource_loader.js:218: function doWait() {
nit: var doWait = function() {...};

[1]
https://google.github.io/styleguide/javascriptguide.xml?showone=Function_Decl...

https://codereview.chromium.org/2004553002/diff/1/ui/login/resource_loader.js...
ui/login/resource_loader.js:228: setTimeout(doWait, 0);
nit: Would window.requestAnimationFrame be better since it is called before the
next repaint?

[jdufault, 2016-05-20 21:31:06]

https://codereview.chromium.org/2004553002/diff/1/ui/login/resource_loader.js
File ui/login/resource_loader.js (right):

https://codereview.chromium.org/2004553002/diff/1/ui/login/resource_loader.js...
ui/login/resource_loader.js:218: function doWait() {
On 2016/05/20 21:06:32, xiyuan wrote:
> nit: var doWait = function() {...};
> 
> [1]
>
https://google.github.io/styleguide/javascriptguide.xml?showone=Function_Decl...

Done.

https://codereview.chromium.org/2004553002/diff/1/ui/login/resource_loader.js...
ui/login/resource_loader.js:228: setTimeout(doWait, 0);
On 2016/05/20 21:06:32, xiyuan wrote:
> nit: Would window.requestAnimationFrame be better since it is called before
the
> next repaint?

Makes sense. Done.

[xiyuan, 2016-05-20 21:48:33]

lgtm

https://codereview.chromium.org/2004553002/diff/20001/ui/login/resource_loade...
File ui/login/resource_loader.js (right):

https://codereview.chromium.org/2004553002/diff/20001/ui/login/resource_loade...
ui/login/resource_loader.js:226: }
nit: add a semicolon, i.e. }; , since this is a statement now.

[jdufault, 2016-05-20 22:34:38]

https://codereview.chromium.org/2004553002/diff/20001/ui/login/resource_loade...
File ui/login/resource_loader.js (right):

https://codereview.chromium.org/2004553002/diff/20001/ui/login/resource_loade...
ui/login/resource_loader.js:226: }
On 2016/05/20 21:48:33, xiyuan wrote:
> nit: add a semicolon, i.e. }; , since this is a statement now. 

Done.

[jdufault, 2016-05-20 22:34:41]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-05-20 22:34:41]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2004553002/#ps40001
(title: "Add semicolon")

[commit-bot: I haz the power, 2016-05-20 22:35:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004553002/40001

[commit-bot: I haz the power, 2016-05-21 01:08:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-21 01:08:30]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jdufault, 2016-05-23 17:06:10]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-05-23 17:06:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004553002/40001

[commit-bot: I haz the power, 2016-05-23 17:55:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-23 17:56:51]

Description was changed from

==========
Fix opacity transition of pin keyboard on lockscreen.

Before, the opacity would get adjusted before the keyboard had been completely
loaded into the DOM. This patch makes the opacity adjustment wait until after
the pin keyboard has layout information available.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix opacity transition of pin keyboard on lockscreen.

Before, the opacity would get adjusted before the keyboard had been completely
loaded into the DOM. This patch makes the opacity adjustment wait until after
the pin keyboard has layout information available.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c8e72b2a44ffc2232cf10fcf4463f6c13672d5b8
Cr-Commit-Position: refs/heads/master@{#395359}
==========

[commit-bot: I haz the power, 2016-05-23 17:56:52]

Patchset 3 (id:??) landed as
https://crrev.com/c8e72b2a44ffc2232cf10fcf4463f6c13672d5b8
Cr-Commit-Position: refs/heads/master@{#395359}