Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2326)

Unified Diff: chrome/browser/resources/chromeos/login/lock.js

Issue 2004553002: Fix opacity transition of pin keyboard on lockscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Add semicolon Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/login/resource_loader.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/login/lock.js
diff --git a/chrome/browser/resources/chromeos/login/lock.js b/chrome/browser/resources/chromeos/login/lock.js
index 89f3e1cb4bcdbc6617a68837287f68e33ed86d47..c1147ef2121f47d0d16ee7cb063a2b1722b1f506 100644
--- a/chrome/browser/resources/chromeos/login/lock.js
+++ b/chrome/browser/resources/chromeos/login/lock.js
@@ -19,8 +19,7 @@
});
// Called after polymer has been loaded. Fades the pin element in.
- var onPolymerLoaded = function() {
- var pinContainer = $('pin-container');
+ var onPinLoaded = function(pinContainer) {
pinContainer.style.opacity = 1;
};
@@ -31,8 +30,10 @@
// animations. We load the PIN after an idle notification to allow the pod
// fly-in animation to complete without interruption.
if (loadTimeData.getBoolean('showPin')) {
- cr.ui.login.ResourceLoader.loadAssetsOnIdle('custom-elements',
- onPolymerLoaded);
+ cr.ui.login.ResourceLoader.loadAssetsOnIdle('custom-elements', function() {
+ cr.ui.login.ResourceLoader.waitUntilLayoutComplete('pin-container',
+ onPinLoaded);
+ });
}
})();
« no previous file with comments | « no previous file | ui/login/resource_loader.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698