Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2004523002: Revert of [sync] Sign user out of Chrome on dashboard stop and reset (Closed)

Created:
4 years, 7 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 7 months ago
CC:
sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sync] Sign user out of Chrome on dashboard stop and reset (patchset #4 id:160001 of https://codereview.chromium.org/1976423002/ ) Reason for revert: New test testStopAndClear causes findbugs error on Clank ToT bot. BUG=613629 Original issue's description: > [sync] Sign user out of Chrome on dashboard stop and reset > > Currently every platform except Android and ChromeOS log out of chrome upon a > dashboard stop and clear. This CL removes the special case for Android and adds > some machinery to notify Android Java code that sign out occurred. This > notification prompts Android's SigninManager to clear Android specific state. > > BUG=596611 > > R=maxbogue@chromium.org > > Committed: https://crrev.com/359ced3af82ddfc61114a801c62b1da4c79e7565 > Cr-Commit-Position: refs/heads/master@{#395099} TBR=maxbogue@chromium.org,pnoland@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596611 Committed: https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95 Cr-Commit-Position: refs/heads/master@{#395115}

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
aelias_OOO_until_Jul13
Created Revert of [sync] Sign user out of Chrome on dashboard stop and reset
4 years, 7 months ago (2016-05-20 18:03:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004523002/1
4 years, 7 months ago (2016-05-20 18:04:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 18:04:38 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 18:06:06 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae1c373ff95da3c1386ddf89422036e29a396c95
Cr-Commit-Position: refs/heads/master@{#395115}

Powered by Google App Engine
This is Rietveld 408576698