components/browser_sync/browser/profile_sync_service.cc - Issue 2004523002: Revert of [sync] Sign user out of Chrome on dashboard stop and reset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/browser/profile_sync_service.cc

Issue 2004523002: Revert of [sync] Sign user out of Chrome on dashboard stop and reset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/signin/signin_manager_android.cc ('k') | components/browser_sync/browser/profile_sync_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_sync/browser/profile_sync_service.cc

diff --git a/components/browser_sync/browser/profile_sync_service.cc b/components/browser_sync/browser/profile_sync_service.cc

index 304e3827347fac97044c0408740487a1fddbc8db..782f56c947264696e8a039d7868ff8ff8a09f06f 100644

--- a/components/browser_sync/browser/profile_sync_service.cc

+++ b/components/browser_sync/browser/profile_sync_service.cc

@@ -1283,9 +1283,8 @@

syncer::STOP_SOURCE_LIMIT);

}

RequestStop(CLEAR_DATA);

-#if !defined(OS_CHROMEOS)

- // On every platform except ChromeOS, sign out the user after a dashboard

- // clear.

+#if !defined(OS_CHROMEOS) && !defined(OS_ANDROID)

+ // On desktop and iOS, sign out the user after a dashboard clear.

static_cast<SigninManager*>(signin_->GetOriginal())

->SignOut(signin_metrics::SERVER_FORCED_DISABLE,

signin_metrics::SignoutDelete::IGNORE_METRIC);