Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2004443002: cc: Update SpreadForStdDeviation to 3*sigma, and update tests. (Closed)

Created:
4 years, 7 months ago by jbroman
Modified:
4 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Update SpreadForStdDeviation to 3*sigma, and update tests. A recent change (https://codereview.chromium.org/1980613003) updated one path to use 3*sigma as the estimated spread for gaussian blurs in filters. This propagates that change to the "filter outset" path, for consistency, and updates test results accordingly (including one visually-indistinguishable pixel diff). BUG=600821 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6797dde5c989f574af49c2b5a81bb07a4491861e Cr-Commit-Position: refs/heads/master@{#395126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M cc/output/filter_operation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/filter_operations.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M cc/output/filter_operations_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M cc/test/data/background_filter_rotated_gl.png View Binary file 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jbroman
It seems that we should probably keep the definition of Gaussian blur spread consistent across ...
4 years, 7 months ago (2016-05-20 17:52:37 UTC) #3
Stephen White
LGTM We should really wean the code off of the GetOutsets() path.
4 years, 7 months ago (2016-05-20 17:57:12 UTC) #4
jbroman
On 2016/05/20 at 17:57:12, senorblanco wrote: > LGTM > > We should really wean the ...
4 years, 7 months ago (2016-05-20 17:58:13 UTC) #5
enne (OOO)
lgtm
4 years, 7 months ago (2016-05-20 18:00:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004443002/1
4 years, 7 months ago (2016-05-20 18:29:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 19:00:06 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 19:01:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6797dde5c989f574af49c2b5a81bb07a4491861e
Cr-Commit-Position: refs/heads/master@{#395126}

Powered by Google App Engine
This is Rietveld 408576698