cc: correctly fix edge-AA for filtered render surfaces.

cc: correctly fix edge-AA for filtered render surfaces.

Moving the destination bounds computation above the edge-AA computations
allows us to give correct positions for the edge-AA edges on filtered
quads. This is a change which will be necessary for an upcoming
optimization.

This required adding a matrix param to FilterOperation[s].MapRect().
Since this function is called with device-space rects, so it should also
be passed a matrix to transform the filter parameters into device space.

BUG=611823
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a
Cr-Commit-Position: refs/heads/master@{#393657}

[Stephen White, 2016-05-13 18:59:35]

Description was changed from

==========
cc: correctly fix edge-AA for filtered render surfaces.

Moving the destination bounds computation above the edge-AA computations
allows us to give correct positions for the edge-AA edges on filtered
quads. This is a change which will be necessary for an upcoming
optimization.

This required adding a matrix param to FilterOperation[s].MapRect().
Since this function is called with device-space rects, so it should also
be passed a matrix to transform the filter parameters into device space.

BUG=611823
==========

to

==========
cc: correctly fix edge-AA for filtered render surfaces.

Moving the destination bounds computation above the edge-AA computations
allows us to give correct positions for the edge-AA edges on filtered
quads. This is a change which will be necessary for an upcoming
optimization.

This required adding a matrix param to FilterOperation[s].MapRect().
Since this function is called with device-space rects, so it should also
be passed a matrix to transform the filter parameters into device space.

BUG=611823
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Stephen White, 2016-05-13 19:08:31]

senorblanco@chromium.org changed reviewers:
+ enne@chromium.org

[Stephen White, 2016-05-13 19:08:32]

enne: PTAL.

My previous fix for this (https://codereview.chromium.org/1942863002) proved
incompatible with the upcoming Skia change.

So I've rewritten it to use correct edge AA instead.

[Stephen White, 2016-05-13 19:08:37]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 19:09:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980613003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980613003/20001

[Stephen White, 2016-05-13 19:14:02]

The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 19:14:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980613003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980613003/40001

[commit-bot: I haz the power, 2016-05-13 20:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 20:39:51]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2016-05-13 21:31:13]

Looks good in general but

https://codereview.chromium.org/1980613003/diff/40001/cc/output/filter_operat...
File cc/output/filter_operation.cc (right):

https://codereview.chromium.org/1980613003/diff/40001/cc/output/filter_operat...
cc/output/filter_operation.cc:318: static SkVector MapStdDeviation(float
std_deviation, const SkMatrix& matrix) {
Can you explain this change to me?

[Stephen White, 2016-05-13 21:51:07]

https://codereview.chromium.org/1980613003/diff/40001/cc/output/filter_operat...
File cc/output/filter_operation.cc (right):

https://codereview.chromium.org/1980613003/diff/40001/cc/output/filter_operat...
cc/output/filter_operation.cc:318: static SkVector MapStdDeviation(float
std_deviation, const SkMatrix& matrix) {
On 2016/05/13 21:31:13, enne wrote:
> Can you explain this change to me?

Basically, this syncs this function up with the Skia implementation, 
so this function gives the same result as calling filterBounds() on 
the built SkImageFilter DAG would give.

(Since we don't use the triple-box-blur on the GPU path, the 
previous version was not accurate anyway. We use 3 * sigma in
Skia since it's a Gaussian blur and 99.7 percent of the samples 
fall within 3 sigmas of the mean. The function also applies the 
matrix, which in practice is always a scaling matrix.)

[enne (OOO), 2016-05-13 21:57:47]

lgtm

[Stephen White, 2016-05-13 21:58:07]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2016-05-13 21:59:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980613003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980613003/40001

[commit-bot: I haz the power, 2016-05-13 22:04:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-13 22:06:43]

Description was changed from

==========
cc: correctly fix edge-AA for filtered render surfaces.

Moving the destination bounds computation above the edge-AA computations
allows us to give correct positions for the edge-AA edges on filtered
quads. This is a change which will be necessary for an upcoming
optimization.

This required adding a matrix param to FilterOperation[s].MapRect().
Since this function is called with device-space rects, so it should also
be passed a matrix to transform the filter parameters into device space.

BUG=611823
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: correctly fix edge-AA for filtered render surfaces.

Moving the destination bounds computation above the edge-AA computations
allows us to give correct positions for the edge-AA edges on filtered
quads. This is a change which will be necessary for an upcoming
optimization.

This required adding a matrix param to FilterOperation[s].MapRect().
Since this function is called with device-space rects, so it should also
be passed a matrix to transform the filter parameters into device space.

BUG=611823
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a
Cr-Commit-Position: refs/heads/master@{#393657}
==========

[commit-bot: I haz the power, 2016-05-13 22:06:44]

Patchset 3 (id:??) landed as
https://crrev.com/60471d41ca8bf96b3a487c086ceefe2aca7d126a
Cr-Commit-Position: refs/heads/master@{#393657}