[json] support property list argument in BasicJsonStringifier.

[json] support property list argument in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/fb8e0ab3ee90cd1fabf6625214a1e36b9f84defe
Cr-Commit-Position: refs/heads/master@{#36478}

[Camillo Bruni, 2016-05-24 11:14:50]

LGTM with nit

https://codereview.chromium.org/2004413002/diff/1/src/js/json.js
File src/js/json.js (right):

https://codereview.chromium.org/2004413002/diff/1/src/js/json.js#newcode130
src/js/json.js:130: if (gap != "") member += " ";
nit: you could directly combine ":" and ": " here.

https://codereview.chromium.org/2004413002/diff/1/src/json-stringifier.cc
File src/json-stringifier.cc (right):

https://codereview.chromium.org/2004413002/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:159: } else if (value->IsNumber()) {
better :)

[Yang, 2016-05-24 11:52:50]

https://codereview.chromium.org/2004413002/diff/1/src/js/json.js
File src/js/json.js (right):

https://codereview.chromium.org/2004413002/diff/1/src/js/json.js#newcode130
src/js/json.js:130: if (gap != "") member += " ";
On 2016/05/24 11:14:50, Camillo Bruni wrote:
> nit: you could directly combine ":" and ": " here.

This is old code that should soon go away completely. I'll opt out of improving
this :)

[Yang, 2016-05-24 11:52:54]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-05-24 11:53:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004413002/1

[commit-bot: I haz the power, 2016-05-24 11:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 11:54:29]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Yang, 2016-05-24 13:22:59]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-24 13:22:59]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2004413002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-24 13:23:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004413002/20001

[commit-bot: I haz the power, 2016-05-24 13:56:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-24 13:56:55]

Description was changed from

==========
[json] support property list argument in BasicJsonStringifier.

R=cbruni@chromium.org
==========

to

==========
[json] support property list argument in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/fb8e0ab3ee90cd1fabf6625214a1e36b9f84defe
Cr-Commit-Position: refs/heads/master@{#36478}
==========

[commit-bot: I haz the power, 2016-05-24 13:56:56]

Patchset 2 (id:??) landed as
https://crrev.com/fb8e0ab3ee90cd1fabf6625214a1e36b9f84defe
Cr-Commit-Position: refs/heads/master@{#36478}