[json] support replacer function in BasicJsonStringifier.

[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}

Committed: https://crrev.com/abdd1077e3fc4b997c07739c92fcad55feea5c3b
Cr-Commit-Position: refs/heads/master@{#36514}

[Yang, 2016-05-24 14:51:54]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 14:51:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010533002/20001

[commit-bot: I haz the power, 2016-05-24 15:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 15:11:26]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Camillo Bruni, 2016-05-24 18:24:55]

LGTM with nits

https://codereview.chromium.org/2010533002/diff/40001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/2010533002/diff/40001/src/builtins.cc#newcode...
src/builtins.cc:2190: args.atOrUndefined(isolate, 3)));
nit: would you mind fetching the arguments into separate variables first?

https://codereview.chromium.org/2010533002/diff/40001/src/json-stringifier.cc
File src/json-stringifier.cc (right):

https://codereview.chromium.org/2010533002/diff/40001/src/json-stringifier.cc...
src/json-stringifier.cc:233: return
Handle<JSReceiver>(JSReceiver::cast(elements->get(length - 1)));
use isolate_ directly here, avoids the massive ;) GetIsolate() overhead...

[Camillo Bruni, 2016-05-24 18:25:02]

LGTM with nits

[Yang, 2016-05-25 08:09:58]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-25 08:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2010533002/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-25 08:10:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010533002/60001

[commit-bot: I haz the power, 2016-05-25 08:45:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-25 08:46:43]

Description was changed from

==========
[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org
==========

to

==========
[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}
==========

[commit-bot: I haz the power, 2016-05-25 08:46:44]

Patchset 4 (id:??) landed as
https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}

[Michael Achenbach, 2016-05-25 10:49:48]

Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Could you fix or revert?

[Yang, 2016-05-25 11:35:35]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2008293002/ by yangguo@chromium.org.

The reason for reverting is: Layout test failure:

https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Yang, 2016-05-25 11:43:48]

Description was changed from

==========
[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}
==========

to

==========
[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}
==========

[Yang, 2016-05-25 12:02:57]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-05-25 12:02:57]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2010533002/#ps80001
(title: "fix")

[commit-bot: I haz the power, 2016-05-25 12:03:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010533002/80001

[commit-bot: I haz the power, 2016-05-25 12:32:16]

Description was changed from

==========
[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}
==========

to

==========
[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}
==========

[commit-bot: I haz the power, 2016-05-25 12:32:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-25 12:33:57]

Description was changed from

==========
[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}
==========

to

==========
[json] support replacer function in BasicJsonStringifier.

R=cbruni@chromium.org

Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb
Cr-Commit-Position: refs/heads/master@{#36499}

Committed: https://crrev.com/abdd1077e3fc4b997c07739c92fcad55feea5c3b
Cr-Commit-Position: refs/heads/master@{#36514}
==========

[commit-bot: I haz the power, 2016-05-25 12:33:58]

Patchset 5 (id:??) landed as
https://crrev.com/abdd1077e3fc4b997c07739c92fcad55feea5c3b
Cr-Commit-Position: refs/heads/master@{#36514}