Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2004373004: Revert "Fix capturing variables in optimized compilations" (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix capturing variables in optimized compilations" This reverts commit 4dca5d0e012756faa08991c55098f8a566968e63. It seems to cause at least one additional test failure: Repro: python tools/test.py -mrelease -asimarm64 --write-debug-log --write-test-outcome-log --copy-coredumps -cprecompiler -rdart_precompiled --exclude-suite pkg -t480 language/async_star_regression_fisk_test BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/80d6af1e0c2a349b010dd1e4f514d785a1e8ff03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -76 lines) Patch
M runtime/vm/ast.h View 1 chunk +3 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 4 chunks +10 lines, -38 lines 0 comments Download
D tests/language/regress_26453_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Florian Schneider
Seems there is still a problem with this change.
4 years, 7 months ago (2016-05-25 11:25:54 UTC) #2
Vyacheslav Egorov (Google)
rubberstamp
4 years, 7 months ago (2016-05-25 11:28:22 UTC) #3
Vyacheslav Egorov (Google)
rubberstamp lgtm
4 years, 7 months ago (2016-05-25 11:28:33 UTC) #4
Florian Schneider
Committed patchset #1 (id:1) manually as 80d6af1e0c2a349b010dd1e4f514d785a1e8ff03 (presubmit successful).
4 years, 7 months ago (2016-05-25 11:30:30 UTC) #6
hausner
4 years, 7 months ago (2016-05-25 17:15:59 UTC) #7
Message was sent while issue was closed.
Thanks for backing out. The same error can also be reproduced by running the
test with the jit version of dart and the --compile_all flag.

Back to the drawing board...

Powered by Google App Engine
This is Rietveld 408576698