runtime/vm/flow_graph_builder.cc - Issue 2004373004: Revert "Fix capturing variables in optimized compilations"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 2004373004: Revert "Fix capturing variables in optimized compilations" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index 39f41b7e8834de6e1a063b959a194f268629f61b..bd0766772282199d0ecb66842c6d4865270fea02 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -2411,7 +2411,6 @@ void EffectGraphVisitor::VisitClosureNode(ClosureNode* node) {

// compiler. If it was not, set it here.

if (function.context_scope() == ContextScope::null()) {

ASSERT(!is_implicit);

- ASSERT(node->scope() != NULL);

const ContextScope& context_scope = ContextScope::ZoneHandle(

Z, node->scope()->PreserveOuterScope(owner()->context_level()));

ASSERT(!function.HasCode());

« no previous file with comments | « runtime/vm/ast.h ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »