Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2004313005: Move TextAutosizer::Cluster::Cluster() implementation to .cpp. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
wkorman, eae, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move TextAutosizer::Cluster::Cluster() implementation to .cpp. This way we won't have to include LayoutObject.h in the header. Also need an explicit ~TextAutoSizer() in the .cpp file now, because ComputedStyle is only forward-declared in the header file, and TextAutoSizer has a ComputedStyle RefPtr Vector. The need for this was presumably introduced by https://codereview.chromium.org/1999343002 BUG=614015 Committed: https://crrev.com/ae057e0a986c713b8d3b619d1e0f4be61a3f963c Cr-Commit-Position: refs/heads/master@{#395773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -19 lines) Patch
M third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.h View 3 chunks +12 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-24 22:23:14 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-24 22:28:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004313005/1
4 years, 7 months ago (2016-05-24 23:22:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 01:50:15 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 01:52:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae057e0a986c713b8d3b619d1e0f4be61a3f963c
Cr-Commit-Position: refs/heads/master@{#395773}

Powered by Google App Engine
This is Rietveld 408576698