Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20041002: Make CertificateHandler a proper interface of CertificateImporter. (Closed)

Created:
7 years, 5 months ago by pneubeck (no reviews)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, gauravsh+watch_chromium.org, gspencer+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, tfarina
Visibility:
Public.

Description

Make CertificateHandler a proper interface of CertificateImporter. - Change CertificateHandler into a pure interface onc::CertificateImporter. - Make the old onc::CertificateImporter an implementation of that interface. - Replace the unnecessary CertificateImporter::ParseResult by a simple bool. This also frees the name CertificateHandler for other purposes. BUG=NONE TBR=stevenjb@chromium.org (gyp change), eroman@chromium.org (net-internals: API usage) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213860

Patch Set 1 : . #

Patch Set 2 : Rebased. #

Total comments: 10

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -1027 lines) Patch
M chrome/browser/chromeos/cros/network_library_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_impl.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_impl_cros.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_impl_cros.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_impl_cros_unittest.cc View 10 chunks +37 lines, -33 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/chromeos.gyp View 4 chunks +5 lines, -6 lines 0 comments Download
D chromeos/network/certificate_handler.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chromeos/network/certificate_handler.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chromeos/network/mock_certificate_handler.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chromeos/network/mock_certificate_handler.cc View 1 chunk +0 lines, -15 lines 0 comments Download
A + chromeos/network/onc/mock_certificate_importer.h View 1 2 1 chunk +11 lines, -8 lines 0 comments Download
A + chromeos/network/onc/mock_certificate_importer.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_certificate_importer.h View 1 2 1 chunk +16 lines, -78 lines 0 comments Download
D chromeos/network/onc/onc_certificate_importer.cc View 1 chunk +0 lines, -333 lines 0 comments Download
A + chromeos/network/onc/onc_certificate_importer_impl.h View 1 2 4 chunks +30 lines, -37 lines 0 comments Download
A + chromeos/network/onc/onc_certificate_importer_impl.cc View 9 chunks +40 lines, -22 lines 0 comments Download
A + chromeos/network/onc/onc_certificate_importer_impl_unittest.cc View 14 chunks +28 lines, -31 lines 0 comments Download
D chromeos/network/onc/onc_certificate_importer_unittest.cc View 1 chunk +0 lines, -324 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pneubeck (no reviews)
Mostly trivial renaming. Please take a look.
7 years, 5 months ago (2013-07-23 15:25:26 UTC) #1
Mattias Nissler (ping if slow)
LGTM w/ nits https://codereview.chromium.org/20041002/diff/13022/chrome/browser/policy/browser_policy_connector.cc File chrome/browser/policy/browser_policy_connector.cc (right): https://codereview.chromium.org/20041002/diff/13022/chrome/browser/policy/browser_policy_connector.cc#newcode216 chrome/browser/policy/browser_policy_connector.cc:216: cert_importer.Pass())); why not make_scoped_ptr<chromeos::onc::CertificateImporter>( new chromeos::onc::CertificateImporterImpl) ...
7 years, 5 months ago (2013-07-24 11:25:39 UTC) #2
pneubeck (no reviews)
https://codereview.chromium.org/20041002/diff/13022/chrome/browser/policy/browser_policy_connector.cc File chrome/browser/policy/browser_policy_connector.cc (right): https://codereview.chromium.org/20041002/diff/13022/chrome/browser/policy/browser_policy_connector.cc#newcode216 chrome/browser/policy/browser_policy_connector.cc:216: cert_importer.Pass())); On 2013/07/24 11:25:40, Mattias Nissler wrote: > why ...
7 years, 5 months ago (2013-07-25 08:03:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/20041002/38001
7 years, 5 months ago (2013-07-25 08:08:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/20041002/38001
7 years, 5 months ago (2013-07-25 14:07:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/20041002/38001
7 years, 5 months ago (2013-07-26 01:48:14 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 12:20:22 UTC) #7
Message was sent while issue was closed. 
Change committed as 213860

Powered by Google App Engine
This is Rietveld 408576698