Make CertificateHandler a proper interface of CertificateImporter.

chrome/browser/policy/browser_policy_connector.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/browser_policy_connector.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/bind.h"
@@ skipping 42 matching lines @@
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/policy/app_pack_updater.h"
 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_local_account.h"
 #include "chrome/browser/chromeos/policy/device_local_account_policy_service.h"
 #include "chrome/browser/chromeos/policy/device_status_collector.h"
 #include "chrome/browser/chromeos/policy/enterprise_install_attributes.h"
 #include "chrome/browser/chromeos/policy/network_configuration_updater.h"
 #include "chrome/browser/chromeos/policy/network_configuration_updater_impl.h"
+#include "chrome/browser/chromeos/policy/network_configuration_updater_impl_cros.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/cros_settings_provider.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #include "chrome/browser/chromeos/system/statistics_provider.h"
 #include "chrome/browser/chromeos/system/timezone_settings.h"
 #include "chromeos/chromeos_paths.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/cryptohome/cryptohome_library.h"
 #include "chromeos/dbus/cryptohome_client.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
-#include "chromeos/network/certificate_handler.h"
 #include "chromeos/network/managed_network_configuration_handler.h"
+#include "chromeos/network/onc/onc_certificate_importer_impl.h"
 #endif
 
 using content::BrowserThread;
 
 namespace policy {
 
 namespace {
 
 // The following constants define delays applied before the initial policy fetch
 // on startup. (So that displaying Chrome's GUI does not get delayed.)
@@ skipping 115 matching lines @@
 #endif
 
   policy_statistics_collector_.reset(
       new policy::PolicyStatisticsCollector(
           GetPolicyService(),
           local_state_,
           base::MessageLoop::current()->message_loop_proxy()));
   policy_statistics_collector_->Initialize();
 
 #if defined(OS_CHROMEOS)
+  scoped_ptr<chromeos::onc::CertificateImporter> cert_importer(
+      new chromeos::onc::CertificateImporterImpl);
   network_configuration_updater_.reset(
       new NetworkConfigurationUpdaterImpl(
           GetPolicyService(),
-          make_scoped_ptr(new chromeos::CertificateHandler)));
+          cert_importer.Pass()));

[Mattias Nissler (ping if slow), 2013/07/24 11:25:40]

why not

make_scoped_ptr<chromeos::onc::CertificateImporter>(
    new chromeos::onc::CertificateImporterImpl)

[pneubeck (no reviews), 2013/07/25 08:03:23]

Done.

 #endif
 
   is_initialized_ = true;
 }
 
 void BrowserPolicyConnector::Shutdown() {
   is_initialized_ = false;
 
   if (g_testing_provider)
     g_testing_provider->Shutdown();
@@ skipping 249 matching lines @@
     return new AsyncPolicyProvider(loader.Pass());
   } else {
     return NULL;
   }
 #else
   return NULL;
 #endif
 }
 
 }  // namespace policy