Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 2003993002: Disallow throttling while running requestAnimationFrame callbacks (Closed)

Created:
4 years, 7 months ago by Sami
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Disallow throttling while running requestAnimationFrame callbacks If a requestAnimationFrame callback tries to do a synchronous style computation in another frame which is currently throttled, this fails because throttling is allowed for the entire BeginMainFrame, which includes running rAF callbacks as a substep. This patch fixes the issue by disallowing throttling while executing rAF callbacks. Note that rAF callbacks for throttled frames are still skipped. BUG=607336 Review-Url: https://codereview.chromium.org/1994133002 Cr-Commit-Position: refs/heads/master@{#395054} (cherry picked from commit afdf51c967149db6bd8d6a533886efc957435e18) Committed: https://chromium.googlesource.com/chromium/src/+/6c49b69538a2b834e6e463195147ac239291672e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentLifecycle.h View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentLifecycle.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Sami
4 years, 7 months ago (2016-05-23 11:35:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c49b69538a2b834e6e463195147ac239291672e.

Powered by Google App Engine
This is Rietveld 408576698