Disallow throttling while running requestAnimationFrame callbacks

Disallow throttling while running requestAnimationFrame callbacks

If a requestAnimationFrame callback tries to do a synchronous style
computation in another frame which is currently throttled, this fails
because throttling is allowed for the entire BeginMainFrame, which
includes running rAF callbacks as a substep.

This patch fixes the issue by disallowing throttling while executing rAF
callbacks. Note that rAF callbacks for throttled frames are still
skipped.

BUG=607336
Committed: https://crrev.com/afdf51c967149db6bd8d6a533886efc957435e18
Cr-Commit-Position: refs/heads/master@{#395054}

[Sami, 2016-05-19 18:43:33]

Description was changed from

==========
Disallow throttling while running requestAnimationFrame callbacks

If a requestAnimationFrame callback tries to do a synchronous style
computation in another frame which is currently throttled, this fails
because throttling is allowed for the entire BeginMainFrame, which
includes running rAF callbacks as a substep.

This patch fixes the issue by disallowing throttling while executing rAF
callbacks. Note that rAF callbacks for throttled frames are still
skipped.

BUG=607336
==========

to

==========
Disallow throttling while running requestAnimationFrame callbacks

If a requestAnimationFrame callback tries to do a synchronous style
computation in another frame which is currently throttled, this fails
because throttling is allowed for the entire BeginMainFrame, which
includes running rAF callbacks as a substep.

This patch fixes the issue by disallowing throttling while executing rAF
callbacks. Note that rAF callbacks for throttled frames are still
skipped.

BUG=607336
==========

[Sami, 2016-05-19 18:43:33]

skyostil@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Sami, 2016-05-19 18:43:44]

PTAL.

[esprehn, 2016-05-19 18:53:58]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-05-19 18:53:59]

You can just add a C++ raf callback, you don't need to write script for the
test.

https://codereview.chromium.org/1994133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp (right):

https://codereview.chromium.org/1994133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp:838: " 
window.setTimeout(function() {\n"
I don't think we want this delay, just run the right sequence of calls inside
the test. Ex. Composite the first frame or something. You shouldn't need to
setTimeout, your test is the scheduler.

[Sami, 2016-05-19 19:05:20]

> You can just add a C++ raf callback, you don't need to write script for the
test.

I was thinking the mutation and style recalc parts are a little more concise an
realistic using actual script. WDYT know that I've removed the timeout?

https://codereview.chromium.org/1994133002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp (right):

https://codereview.chromium.org/1994133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp:838: " 
window.setTimeout(function() {\n"
On 2016/05/19 18:53:59, esprehn wrote:
> I don't think we want this delay, just run the right sequence of calls inside
> the test. Ex. Composite the first frame or something. You shouldn't need to
> setTimeout, your test is the scheduler.

Good point, done.

[esprehn, 2016-05-20 00:41:35]

https://codereview.chromium.org/1994133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp (right):

https://codereview.chromium.org/1994133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp:847: "  var
throttledFrame = window.parent.frames['first'];\n"
.first, you don't need to use indexed access.

[esprehn, 2016-05-20 00:42:10]

I do think just using a C++ callback is more clear, but this is lgtm with the
simplification made for .first

[Sami, 2016-05-20 09:31:10]

https://codereview.chromium.org/1994133002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp (right):

https://codereview.chromium.org/1994133002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp:847: "  var
throttledFrame = window.parent.frames['first'];\n"
On 2016/05/20 00:41:35, esprehn wrote:
> .first, you don't need to use indexed access.

Thanks, done.

[Sami, 2016-05-20 09:31:16]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-05-20 09:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/1994133002/#ps60001
(title: "Another simplification")

[commit-bot: I haz the power, 2016-05-20 09:31:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994133002/60001

[commit-bot: I haz the power, 2016-05-20 11:07:58]

Description was changed from

==========
Disallow throttling while running requestAnimationFrame callbacks

If a requestAnimationFrame callback tries to do a synchronous style
computation in another frame which is currently throttled, this fails
because throttling is allowed for the entire BeginMainFrame, which
includes running rAF callbacks as a substep.

This patch fixes the issue by disallowing throttling while executing rAF
callbacks. Note that rAF callbacks for throttled frames are still
skipped.

BUG=607336
==========

to

==========
Disallow throttling while running requestAnimationFrame callbacks

If a requestAnimationFrame callback tries to do a synchronous style
computation in another frame which is currently throttled, this fails
because throttling is allowed for the entire BeginMainFrame, which
includes running rAF callbacks as a substep.

This patch fixes the issue by disallowing throttling while executing rAF
callbacks. Note that rAF callbacks for throttled frames are still
skipped.

BUG=607336
==========

[commit-bot: I haz the power, 2016-05-20 11:08:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-20 11:09:24]

Description was changed from

==========
Disallow throttling while running requestAnimationFrame callbacks

If a requestAnimationFrame callback tries to do a synchronous style
computation in another frame which is currently throttled, this fails
because throttling is allowed for the entire BeginMainFrame, which
includes running rAF callbacks as a substep.

This patch fixes the issue by disallowing throttling while executing rAF
callbacks. Note that rAF callbacks for throttled frames are still
skipped.

BUG=607336
==========

to

==========
Disallow throttling while running requestAnimationFrame callbacks

If a requestAnimationFrame callback tries to do a synchronous style
computation in another frame which is currently throttled, this fails
because throttling is allowed for the entire BeginMainFrame, which
includes running rAF callbacks as a substep.

This patch fixes the issue by disallowing throttling while executing rAF
callbacks. Note that rAF callbacks for throttled frames are still
skipped.

BUG=607336

Committed: https://crrev.com/afdf51c967149db6bd8d6a533886efc957435e18
Cr-Commit-Position: refs/heads/master@{#395054}
==========

[commit-bot: I haz the power, 2016-05-20 11:09:25]

Patchset 4 (id:??) landed as
https://crrev.com/afdf51c967149db6bd8d6a533886efc957435e18
Cr-Commit-Position: refs/heads/master@{#395054}