Remove dead code from CPDF_InterForm.

Remove dead code from CPDF_InterForm.

Clean up related code.

Committed: https://pdfium.googlesource.com/pdfium/+/db1a24e86d40977fb6d8aa8fa57dadee4c2f1be1

[Lei Zhang, 2016-05-23 16:21:34]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Lei Zhang, 2016-05-23 18:27:58]

thestig@chromium.org changed reviewers:
+ weili@chromium.org

[Wei Li, 2016-05-23 22:26:14]

lgtm

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formc...
File core/fpdfdoc/doc_formcontrol.cpp (right):

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formc...
core/fpdfdoc/doc_formcontrol.cpp:194: for (size_t i = 0;
FX_ArraySize(g_sHighlightingMode); ++i) {
i < FX_ArraySize(g_sHighlightingMode)?

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formf...
File core/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formf...
core/fpdfdoc/doc_formfield.cpp:508: if
(!NotifyListOrComboBoxBeforeChange(opt_value))
Nit: Merge two if stmts

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formf...
core/fpdfdoc/doc_formfield.cpp:917: if (!m_pForm->m_pFormDict)
move this before line 911 so the condition there is a bit simpler?

[Lei Zhang, 2016-05-23 22:52:46]

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formc...
File core/fpdfdoc/doc_formcontrol.cpp (right):

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formc...
core/fpdfdoc/doc_formcontrol.cpp:194: for (size_t i = 0;
FX_ArraySize(g_sHighlightingMode); ++i) {
On 2016/05/23 22:26:14, Wei Li wrote:
> i < FX_ArraySize(g_sHighlightingMode)?

Uh, yes.

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formf...
File core/fpdfdoc/doc_formfield.cpp (right):

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formf...
core/fpdfdoc/doc_formfield.cpp:508: if
(!NotifyListOrComboBoxBeforeChange(opt_value))
On 2016/05/23 22:26:14, Wei Li wrote:
> Nit: Merge two if stmts

Done.

https://codereview.chromium.org/2003853003/diff/100001/core/fpdfdoc/doc_formf...
core/fpdfdoc/doc_formfield.cpp:917: if (!m_pForm->m_pFormDict)
On 2016/05/23 22:26:14, Wei Li wrote:
> move this before line 911 so the condition there is a bit simpler?

I actually moved it to the top.

[Lei Zhang, 2016-05-23 23:54:49]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-05-23 23:54:50]

The patchset sent to the CQ was uploaded after l-g-t-m from weili@chromium.org
Link to the patchset: https://codereview.chromium.org/2003853003/#ps140001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-23 23:54:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003853003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003853003/140001

[commit-bot: I haz the power, 2016-05-23 23:55:13]

Description was changed from

==========
Remove dead code from CPDF_InterForm.

Clean up related code.
==========

to

==========
Remove dead code from CPDF_InterForm.

Clean up related code.

Committed:
https://pdfium.googlesource.com/pdfium/+/db1a24e86d40977fb6d8aa8fa57dadee4c2f...
==========

[commit-bot: I haz the power, 2016-05-23 23:55:14]

Committed patchset #8 (id:140001) as
https://pdfium.googlesource.com/pdfium/+/db1a24e86d40977fb6d8aa8fa57dadee4c2f...