Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 1999313002: Change CPDF_Boolean to use bool instead of FX_BOOL. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@interform
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Change CPDF_Boolean to use bool instead of FX_BOOL. Committed: https://pdfium.googlesource.com/pdfium/+/ded3634145b214b11212a7c53faa8ba15a1789ca

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -87 lines) Patch
M core/fpdfapi/fpdf_parser/cpdf_boolean.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_boolean.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_security_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_security_handler.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h View 2 chunks +2 lines, -3 lines 0 comments Download
M core/fpdfdoc/doc_action.cpp View 1 chunk +1 line, -38 lines 0 comments Download
M core/fpdfdoc/doc_utils.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M core/fpdfdoc/include/fpdf_doc.h View 1 2 chunks +2 lines, -12 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 1 chunk +2 lines, -7 lines 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Lei Zhang
4 years, 7 months ago (2016-05-23 16:22:28 UTC) #2
Wei Li
lgtm
4 years, 7 months ago (2016-05-23 16:28:51 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2003853003 Patch 100001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-23 16:48:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1999313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1999313002/20001
4 years, 7 months ago (2016-05-23 23:57:30 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 00:54:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ded3634145b214b11212a7c53faa8ba15a17...

Powered by Google App Engine
This is Rietveld 408576698