Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2003763002: [DurableStorage] Change navigator.storage from RuntimeEnabled to OriginTrialEnabled (Closed)

Created:
4 years, 7 months ago by iclelland
Modified:
4 years, 7 months ago
Reviewers:
jsbell, Rick Byers
CC:
chromium-reviews, blink-reviews, haraken, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DurableStorage] Change navigator.storage from RuntimeEnabled to OriginTrialEnabled BUG=610500 Committed: https://crrev.com/b65341702d2c1210a9385a7c6d4e1f244d023c70 Cr-Commit-Position: refs/heads/master@{#395616}

Patch Set 1 #

Patch Set 2 : Add extra exposed symbol because of [OTE] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
iclelland
+r jsbell -- It looks like this one was missed when DurableStorage was converted to ...
4 years, 7 months ago (2016-05-24 13:23:20 UTC) #2
jsbell
lgtm
4 years, 7 months ago (2016-05-24 16:22:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003763002/20001
4 years, 7 months ago (2016-05-24 16:23:20 UTC) #5
jsbell
Will probably need API_OWNERS approval to land the virtual/stable change...
4 years, 7 months ago (2016-05-24 16:23:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/188870)
4 years, 7 months ago (2016-05-24 16:29:42 UTC) #8
jsbell
rbyers@ - can you approve?
4 years, 7 months ago (2016-05-24 16:31:34 UTC) #10
Rick Byers
LGTM For reference, intent to experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SISKuRppAwAJ CL that added the origin trial: https://codereview.chromium.org/1964723002
4 years, 7 months ago (2016-05-24 16:47:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003763002/20001
4 years, 7 months ago (2016-05-24 16:51:30 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 16:56:14 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 16:58:39 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b65341702d2c1210a9385a7c6d4e1f244d023c70
Cr-Commit-Position: refs/heads/master@{#395616}

Powered by Google App Engine
This is Rietveld 408576698