Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1964723002:
[DurableStorage] Add origin trial. (Closed)
Description[DurableStorage] Add origin trial.
Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SISKuRppAwAJ
Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373
Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696
BUG=610500
Committed: https://crrev.com/8620d306642a60bfd3e29a6c358b031692a4ead5
Cr-Commit-Position: refs/heads/master@{#393404}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 19 (11 generated)
dmurph@chromium.org changed reviewers: + eae@chromium.org
Hey Emil, Can you PTAL at this change? It's enabling DurableStorage as a origin trial experiment. Thanks! Daniel
Please add a link to the "Intent to Experiment" thread and the feature entry to the description, like this: Intent to Experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/5Sihi1iAXYc/SISKuRpp... Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 LGTM with those changes.
Description was changed from ========== [DurableStorage] Add origin trial. BUG=610500 ========== to ========== [DurableStorage] Add origin trial. Intent to Experiment thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 BUG=610500 ==========
Description was changed from ========== [DurableStorage] Add origin trial. Intent to Experiment thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 BUG=610500 ========== to ========== [DurableStorage] Add origin trial. Intent to Experiment thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 ==========
Description was changed from ========== [DurableStorage] Add origin trial. Intent to Experiment thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 ========== to ========== [DurableStorage] Add origin trial. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 ==========
Done. Thanks!
The CQ bit was checked by dmurph@chromium.org
Description was changed from ========== [DurableStorage] Add origin trial. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 ========== to ========== [DurableStorage] Add origin trial. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964723002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by dmurph@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/1964723002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964723002/20001
Message was sent while issue was closed.
Description was changed from ========== [DurableStorage] Add origin trial. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 ========== to ========== [DurableStorage] Add origin trial. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [DurableStorage] Add origin trial. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 ========== to ========== [DurableStorage] Add origin trial. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/5Sihi1iAXYc/SI... Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=502373 Feature dashboard entry: https://www.chromestatus.com/features/5715811364765696 BUG=610500 Committed: https://crrev.com/8620d306642a60bfd3e29a6c358b031692a4ead5 Cr-Commit-Position: refs/heads/master@{#393404} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8620d306642a60bfd3e29a6c358b031692a4ead5 Cr-Commit-Position: refs/heads/master@{#393404} |
