Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tests/standalone/io/socket_upgrade_to_secure_test.dart

Issue 20036002: Don't throw exceptions when adding to a IOSink(StreamSink) after close. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Document the behaviour. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/socket_exception_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/socket_upgrade_to_secure_test.dart
diff --git a/tests/standalone/io/socket_upgrade_to_secure_test.dart b/tests/standalone/io/socket_upgrade_to_secure_test.dart
index 8564c980fd664954252b43608ea95cb06a9baae8..8c9420a1a010f119292bd84595acce672dc381ca 100644
--- a/tests/standalone/io/socket_upgrade_to_secure_test.dart
+++ b/tests/standalone/io/socket_upgrade_to_secure_test.dart
@@ -160,7 +160,7 @@ void test(bool hostnameInConnect,
future = SecureSocket.secure(socket, host: HOST_NAME);
}
return future.then((secureSocket) {
- Expect.throws(() => socket.add([0]));
+ socket.add([0]);
return secureSocket;
});
});
@@ -174,7 +174,7 @@ void test(bool hostnameInConnect,
future = SecureSocket.secure(socket, host: HOST_NAME);
}
return future.then((secureSocket) {
- Expect.throws(() => socket.add([0]));
+ socket.add([0]);
return secureSocket;
});
});
@@ -186,7 +186,7 @@ void test(bool hostnameInConnect,
server.listen((client) {
if (!handshakeBeforeSecure) {
SecureSocket.secureServer(client, CERTIFICATE).then((secureClient) {
- Expect.throws(() => client.add([0]));
+ client.add([0]);
runServer(secureClient).then((_) => server.close());
});
} else {
@@ -195,7 +195,7 @@ void test(bool hostnameInConnect,
client,
CERTIFICATE,
bufferedData: carryOverData).then((secureClient) {
- Expect.throws(() => client.add([0]));
+ client.add([0]);
runServer(secureClient).then((_) => server.close());
});
});
« no previous file with comments | « tests/standalone/io/socket_exception_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698