Add tests for webRequest events and frame unload

Add tests for webRequest events and frame unload

Tests the following scenarios:

- Load a slow same-origin/cross-origin main/child resource in a frame
  and remove frame/tab.
- Insert a same-origin/cross-origin frame in the document and remove it
  without waiting for the response from the server.

BUG=572930
TEST=./browser_tests --gtest_filter=ExtensionWebRequestApiTest.WebRequestUnloadAfterRequest:ExtensionWebRequestApiTest.WebRequestUnloadImmediately

Committed: https://crrev.com/5d98a647f71dcd17b3ffa3ad1d8100ea77b79dfa
Cr-Commit-Position: refs/heads/master@{#395440}

[robwu, 2016-05-20 21:27:00]

rob@robwu.nl changed reviewers:
+ battre@chromium.org

[robwu, 2016-05-20 21:27:00]

Hi Dominic,

All try bots are green, but while running the tests locally I occasionally get
-1 as tabId during the insertMultipleOriginFramesAndImmediatelyRemoveFrames test
in unload_test6.js

I'll investigate that and follow up with a patch. Meanwhile could you review
this CL? Thanks!

[battre, 2016-05-23 11:17:08]

Only nits.

LGTM

https://codereview.chromium.org/2003593002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/web_request/web_request_apitest.cc (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_request/web_request_apitest.cc:163: //
received.
Rephrase this to "Test that ... happens"?

https://codereview.chromium.org/2003593002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_request/web_request_apitest.cc:178: //
request.
Ditto.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/webrequest/test_unload.js (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload.js:6: // while. You
should try to cancel the request as soon as reasonably possible.
The comment "You should try..." does not seem to belong here in my opinion.
Maybe there should be file level comment on what is tested here and how.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload.js:21: //
getNewSlowURL(), this signals when the request has been processed and that
I guess you have renamed getNewSlowURL to getSlowURL.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/webrequest/test_unload1.js (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload1.js:6: // Opens a
cross-origin frame (a http-URL in this chrome-extension tab) and
s/frame/iframe/

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload1.js:7: // remove it.
nit: removes

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload1.js:16: url,
is "url" a shortcut for url: url?

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/webrequest/test_unload4.js (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload4.js:6: // Load a
slow image in an frame and remove the frame.
nit: in a frame

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/webrequest/test_unload5.js (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload5.js:6: // Start a
XMLHttpRequest in an frame and remove the frame.
nit: a frame

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload5.js:75: // Start a
XMLHttpRequest in the main frame and immediately remove the tab.
nit: "an XMLHttpRequest"

[robwu, 2016-05-23 11:50:49]

Description was changed from

==========
Add tests for webRequest events and frame unload

Tests the following scenarios:

- Load a slow same-origin/cross-origin main/child resource in a frame
  and remove frame/tab.
- Insert a same-origin/cross-origin frame in the document and remove it
  without waiting for the response from the server.

BUG=572930
==========

to

==========
Add tests for webRequest events and frame unload

Tests the following scenarios:

- Load a slow same-origin/cross-origin main/child resource in a frame
  and remove frame/tab.
- Insert a same-origin/cross-origin frame in the document and remove it
  without waiting for the response from the server.

BUG=572930
TEST=./browser_tests
--gtest_filter=ExtensionWebRequestApiTest.WebRequestUnloadAfterRequest:ExtensionWebRequestApiTest.WebRequestUnloadImmediately
==========

[robwu, 2016-05-23 11:51:03]

https://codereview.chromium.org/2003593002/diff/1/chrome/browser/extensions/a...
File chrome/browser/extensions/api/web_request/web_request_apitest.cc (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_request/web_request_apitest.cc:163: //
received.
On 2016/05/23 11:17:07, battre wrote:
> Rephrase this to "Test that ... happens"?

Done.

https://codereview.chromium.org/2003593002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_request/web_request_apitest.cc:178: //
request.
On 2016/05/23 11:17:07, battre wrote:
> Ditto.

Done.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/webrequest/test_unload.js (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload.js:6: // while. You
should try to cancel the request as soon as reasonably possible.
On 2016/05/23 11:17:07, battre wrote:
> The comment "You should try..." does not seem to belong here in my opinion.
> Maybe there should be file level comment on what is tested here and how.

Reworded and added a small file-level comment.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload.js:21: //
getNewSlowURL(), this signals when the request has been processed and that
On 2016/05/23 11:17:07, battre wrote:
> I guess you have renamed getNewSlowURL to getSlowURL.

Done.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/webrequest/test_unload1.js (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload1.js:6: // Opens a
cross-origin frame (a http-URL in this chrome-extension tab) and
On 2016/05/23 11:17:07, battre wrote:
> s/frame/iframe/

Done.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload1.js:7: // remove it.
On 2016/05/23 11:17:07, battre wrote:
> nit: removes

Done.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload1.js:16: url,
On 2016/05/23 11:17:07, battre wrote:
> is "url" a shortcut for url: url?

Yes. That's new in ES6.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/webrequest/test_unload4.js (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload4.js:6: // Load a
slow image in an frame and remove the frame.
On 2016/05/23 11:17:07, battre wrote:
> nit: in a frame

Done.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/webrequest/test_unload5.js (right):

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload5.js:6: // Start a
XMLHttpRequest in an frame and remove the frame.
On 2016/05/23 11:17:08, battre wrote:
> nit: a frame

Done.

https://codereview.chromium.org/2003593002/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/webrequest/test_unload5.js:75: // Start a
XMLHttpRequest in the main frame and immediately remove the tab.
On 2016/05/23 11:17:08, battre wrote:
> nit: "an XMLHttpRequest" 

Done.

[robwu, 2016-05-23 21:26:28]

The CQ bit was checked by rob@robwu.nl

[robwu, 2016-05-23 21:26:32]

The patchset sent to the CQ was uploaded after l-g-t-m from battre@chromium.org
Link to the patchset: https://codereview.chromium.org/2003593002/#ps20001
(title: "battre's nits")

[commit-bot: I haz the power, 2016-05-23 21:27:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2003593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2003593002/20001

[commit-bot: I haz the power, 2016-05-23 22:34:56]

Description was changed from

==========
Add tests for webRequest events and frame unload

Tests the following scenarios:

- Load a slow same-origin/cross-origin main/child resource in a frame
  and remove frame/tab.
- Insert a same-origin/cross-origin frame in the document and remove it
  without waiting for the response from the server.

BUG=572930
TEST=./browser_tests
--gtest_filter=ExtensionWebRequestApiTest.WebRequestUnloadAfterRequest:ExtensionWebRequestApiTest.WebRequestUnloadImmediately
==========

to

==========
Add tests for webRequest events and frame unload

Tests the following scenarios:

- Load a slow same-origin/cross-origin main/child resource in a frame
  and remove frame/tab.
- Insert a same-origin/cross-origin frame in the document and remove it
  without waiting for the response from the server.

BUG=572930
TEST=./browser_tests
--gtest_filter=ExtensionWebRequestApiTest.WebRequestUnloadAfterRequest:ExtensionWebRequestApiTest.WebRequestUnloadImmediately
==========

[commit-bot: I haz the power, 2016-05-23 22:34:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-23 22:36:51]

Description was changed from

==========
Add tests for webRequest events and frame unload

Tests the following scenarios:

- Load a slow same-origin/cross-origin main/child resource in a frame
  and remove frame/tab.
- Insert a same-origin/cross-origin frame in the document and remove it
  without waiting for the response from the server.

BUG=572930
TEST=./browser_tests
--gtest_filter=ExtensionWebRequestApiTest.WebRequestUnloadAfterRequest:ExtensionWebRequestApiTest.WebRequestUnloadImmediately
==========

to

==========
Add tests for webRequest events and frame unload

Tests the following scenarios:

- Load a slow same-origin/cross-origin main/child resource in a frame
  and remove frame/tab.
- Insert a same-origin/cross-origin frame in the document and remove it
  without waiting for the response from the server.

BUG=572930
TEST=./browser_tests
--gtest_filter=ExtensionWebRequestApiTest.WebRequestUnloadAfterRequest:ExtensionWebRequestApiTest.WebRequestUnloadImmediately

Committed: https://crrev.com/5d98a647f71dcd17b3ffa3ad1d8100ea77b79dfa
Cr-Commit-Position: refs/heads/master@{#395440}
==========

[commit-bot: I haz the power, 2016-05-23 22:36:52]

Patchset 2 (id:??) landed as
https://crrev.com/5d98a647f71dcd17b3ffa3ad1d8100ea77b79dfa
Cr-Commit-Position: refs/heads/master@{#395440}