Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 2003593002: Add tests for webRequest events and frame unload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: battre's nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/webrequest/test_unload.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
index 82727fcb3a39373c2d7b9c73024e6703bc83257d..d9750daef3d58625a9bed874e5ceb416ce7faffb 100644
--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
@@ -159,6 +159,32 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, WebRequestTypes) {
ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_types.html")) << message_;
}
+// Test that the webRequest events are dispatched with the expected details when
+// a frame or tab is removed while a response is being received.
+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,
+ WebRequestUnloadAfterRequest) {
+ ASSERT_TRUE(StartEmbeddedTestServer());
+ ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_unload.html?1")) <<
+ message_;
+ ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_unload.html?2")) <<
+ message_;
+ ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_unload.html?3")) <<
+ message_;
+ ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_unload.html?4")) <<
+ message_;
+}
+
+// Test that the webRequest events are dispatched with the expected details when
+// a frame or tab is immediately removed after starting a request.
+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,
+ WebRequestUnloadImmediately) {
+ ASSERT_TRUE(StartEmbeddedTestServer());
+ ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_unload.html?5")) <<
+ message_;
+ ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_unload.html?6")) <<
+ message_;
+}
+
// Flaky (sometimes crash): http://crbug.com/140976
IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,
DISABLED_WebRequestAuthRequired) {
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/webrequest/test_unload.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698