Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 2003433002: SELECT Popup: Fix the right popup padding in RTL. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT Popup: Fix the right popup padding in RTL. LayoutMenuList::clientPaddingRight wasn't RTL-aware. The function is not used in LTR case, so we can remove the conditional code. BUG=605719 Committed: https://crrev.com/35cc4a9bb84d3fd2dfb11bc9b4cec60c7a22457f Cr-Commit-Position: refs/heads/master@{#395013}

Patch Set 1 : #

Messages

Total messages: 9 (4 generated)
tkent
Keishi@, would you review this please?
4 years, 7 months ago (2016-05-20 05:37:23 UTC) #3
keishi
LGTM
4 years, 7 months ago (2016-05-20 05:45:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003433002/20001
4 years, 7 months ago (2016-05-20 05:47:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-20 06:11:40 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 06:12:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35cc4a9bb84d3fd2dfb11bc9b4cec60c7a22457f
Cr-Commit-Position: refs/heads/master@{#395013}

Powered by Google App Engine
This is Rietveld 408576698