Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp

Issue 2003433002: SELECT Popup: Fix the right popup padding in RTL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-rtl-default-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
index 866f3b680c2bd168e5b47e4d3d86821f2c7caa39..7137ce16b95c8bcd6514d9ceef128eca66dd773b 100644
--- a/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutMenuList.cpp
@@ -347,19 +347,8 @@ LayoutUnit LayoutMenuList::clientPaddingLeft() const
return paddingLeft() + m_innerBlock->paddingLeft();
}
-const int endOfLinePadding = 2;
LayoutUnit LayoutMenuList::clientPaddingRight() const
{
- if (style()->appearance() == MenulistPart || style()->appearance() == MenulistButtonPart) {
- // For these appearance values, the theme applies padding to leave room for the
- // drop-down button. But leaving room for the button inside the popup menu itself
- // looks strange, so we return a small default padding to avoid having a large empty
- // space appear on the side of the popup menu.
- return LayoutUnit(endOfLinePadding);
- }
-
- // If the appearance isn't MenulistPart, then the select is styled (non-native), so
- // we want to return the user specified padding.
return paddingRight() + m_innerBlock->paddingRight();
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-appearance-rtl-default-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698