Chromium Code Reviews| Index: Source/bindings/scripts/deprecated_code_generator_v8.pm |
| diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm |
| index cd82aff027380ca35809a45ddab051dae33d2e56..561745c1a63b22ba79a342d48ce5d9d78af2cd22 100644 |
| --- a/Source/bindings/scripts/deprecated_code_generator_v8.pm |
| +++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm |
| @@ -2694,11 +2694,20 @@ END |
| END |
| } |
| + my $declaredFoundBoolean = 0; |
|
haraken
2013/07/23 10:20:57
Nit: This is unused.
|
| foreach my $attribute (@{$interface->attributes}) { |
| if ($attribute->extendedAttributes->{"InitializedByEventConstructor"}) { |
| if ($attribute->type ne "any") { |
| my $attributeName = $attribute->name; |
| - $code .= " options.get(\"$attributeName\", eventInit.$attributeName);\n"; |
| + my $attributeImplName = GetImplName($attribute); |
| + my $deprecation = $attribute->extendedAttributes->{"DeprecateAs"}; |
| + my $dictionaryGetter = "options.get(\"$attributeName\", eventInit.$attributeImplName)"; |
| + if ($deprecation) { |
|
haraken
2013/07/23 10:20:57
Nit: You can just say $attribute->extendedAttribut
|
| + $code .= " if ($dictionaryGetter)\n"; |
| + $code .= " " . GenerateDeprecationNotification($deprecation); |
| + } else { |
| + $code .= " $dictionaryGetter;\n"; |
| + } |
| } |
| } |
| } |