Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Side by Side Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 20034002: Add support for KeyboardEvent.location attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Take Kentaro's feedback into consideration Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 1 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com> 2 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org> 4 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
5 # Copyright (C) 2006 Apple Computer, Inc. 5 # Copyright (C) 2006 Apple Computer, Inc.
6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc. 6 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 7 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
8 # Copyright (C) Research In Motion Limited 2010. All rights reserved. 8 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 # Copyright (C) 2012 Ericsson AB. All rights reserved. 10 # Copyright (C) 2012 Ericsson AB. All rights reserved.
(...skipping 2676 matching lines...) Expand 10 before | Expand all | Expand 10 after
2687 2687
2688 if ($interface->parent) { 2688 if ($interface->parent) {
2689 my $interfaceBase = $interface->parent; 2689 my $interfaceBase = $interface->parent;
2690 $code .= <<END; 2690 $code .= <<END;
2691 if (!fill${interfaceBase}Init(eventInit, options)) 2691 if (!fill${interfaceBase}Init(eventInit, options))
2692 return false; 2692 return false;
2693 2693
2694 END 2694 END
2695 } 2695 }
2696 2696
2697 my $declaredFoundBoolean = 0;
haraken 2013/07/23 10:20:57 Nit: This is unused.
2697 foreach my $attribute (@{$interface->attributes}) { 2698 foreach my $attribute (@{$interface->attributes}) {
2698 if ($attribute->extendedAttributes->{"InitializedByEventConstructor"}) { 2699 if ($attribute->extendedAttributes->{"InitializedByEventConstructor"}) {
2699 if ($attribute->type ne "any") { 2700 if ($attribute->type ne "any") {
2700 my $attributeName = $attribute->name; 2701 my $attributeName = $attribute->name;
2701 $code .= " options.get(\"$attributeName\", eventInit.$attribu teName);\n"; 2702 my $attributeImplName = GetImplName($attribute);
2703 my $deprecation = $attribute->extendedAttributes->{"DeprecateAs" };
2704 my $dictionaryGetter = "options.get(\"$attributeName\", eventIni t.$attributeImplName)";
2705 if ($deprecation) {
haraken 2013/07/23 10:20:57 Nit: You can just say $attribute->extendedAttribut
2706 $code .= " if ($dictionaryGetter)\n";
2707 $code .= " " . GenerateDeprecationNotification($deprecati on);
2708 } else {
2709 $code .= " $dictionaryGetter;\n";
2710 }
2702 } 2711 }
2703 } 2712 }
2704 } 2713 }
2705 2714
2706 $code .= <<END; 2715 $code .= <<END;
2707 return true; 2716 return true;
2708 } 2717 }
2709 2718
2710 END 2719 END
2711 $implementation{nameSpaceWebCore}->add($code); 2720 $implementation{nameSpaceWebCore}->add($code);
(...skipping 3293 matching lines...) Expand 10 before | Expand all | Expand 10 after
6005 if ($currentInterface->extendedAttributes->{$extendedAttribute}) { 6014 if ($currentInterface->extendedAttributes->{$extendedAttribute}) {
6006 $found = 1; 6015 $found = 1;
6007 } 6016 }
6008 return 1 if $found; 6017 return 1 if $found;
6009 }, 0); 6018 }, 0);
6010 6019
6011 return $found; 6020 return $found;
6012 } 6021 }
6013 6022
6014 1; 6023 1;
OLDNEW
« no previous file with comments | « LayoutTests/fast/events/script-tests/keydown-numpad-keys.js ('k') | Source/bindings/tests/idls/TestExtendedEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698