Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2003243002: Mac fullscreen low power: Ignore WasOccluded by low power window (Closed)

Created:
4 years, 7 months ago by ccameron
Modified:
4 years, 7 months ago
Reviewers:
spqchan
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@fullscreen_sort_of
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac fullscreen low power: Ignore WasOccluded by low power window The fullscreen low power window will occlude the main NSWindow. Change the RWHVMac to ignore WasOccluded messages when the fullscreen low power window exists. BUG=594460 Committed: https://crrev.com/80c04977423898bd64b1cfa91246ced5cc35d80b Cr-Commit-Position: refs/heads/master@{#395613}

Patch Set 1 #

Patch Set 2 : fix reversed conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 chunks +22 lines, -8 lines 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
ccameron
ptal: Another small change for this. With this patch, the --enable-fullscreen-low-power-mode makes us enter detached ...
4 years, 7 months ago (2016-05-24 00:28:25 UTC) #2
spqchan
lgtm
4 years, 7 months ago (2016-05-24 00:34:36 UTC) #3
ccameron
Thanks!
4 years, 7 months ago (2016-05-24 00:45:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003243002/1
4 years, 7 months ago (2016-05-24 00:46:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/116036)
4 years, 7 months ago (2016-05-24 01:42:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003243002/20001
4 years, 7 months ago (2016-05-24 16:38:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 16:42:06 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 16:43:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80c04977423898bd64b1cfa91246ced5cc35d80b
Cr-Commit-Position: refs/heads/master@{#395613}

Powered by Google App Engine
This is Rietveld 408576698