Mac fullscreen low power: Add layout interactions and flag

Mac fullscreen low power: Add layout interactions and flag

This instantiates the NSWindow used for fullscreen low power mode, by
creating a FullscreenLowPowerCoordinator when entering fullscreen mode,
and adding it to the fullscreen transition group.

This also adds logic for determining if the layout of the browser chrome
is on-screen, and prevents moving the fullscreen low power window
in front if it is present.

Add a flag to enable this feature during development.

BUG=594460
Committed: https://crrev.com/befa9c961bf06d34403d4f40cc469e1c774b829a
Cr-Commit-Position: refs/heads/master@{#395457}

[ccameron, 2016-05-19 23:53:53]

Description was changed from

==========
Mac fullscreen low power: Add layout interactions

This instantiates the NSWindow used for fullscreen low power mode, by
creating a FullscreenLowPowerCoordinator when entering fullscreen mode,
and adding it to the fullscreen transition group.

This also adds logic for determining if the layout of the browser chrome
is on-screen, and prevents moving the fullscreen low power window
in front if it is present.

This is still missing some things that need to prevent moving the
fullscreen low power mode window from coming forward (print preview and
the fullscreen escape bubble). There also still exist some focus issues
that need to be addressed.

For now the fullscreen low power window will never appear on screen
because the state indicating that the permission bubble has gone away is
never set.

BUG=594460
==========

to

==========
Mac fullscreen low power: Add layout interactions and flag

This instantiates the NSWindow used for fullscreen low power mode, by
creating a FullscreenLowPowerCoordinator when entering fullscreen mode,
and adding it to the fullscreen transition group.

This also adds logic for determining if the layout of the browser chrome
is on-screen, and prevents moving the fullscreen low power window
in front if it is present.

Add a flag to enable this feature during development.

BUG=594460
==========

[ccameron, 2016-05-19 23:53:53]

ccameron@chromium.org changed reviewers:
+ spqchan@chromium.org

[ccameron, 2016-05-19 23:54:03]

ptal

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.mm:58: #include
"chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h"
This is needed because the class needs to be defined because of the new member
variable.

[spqchan, 2016-05-20 00:22:24]

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h (right):

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h:60: // Set if the
NSView heirarchy allows low power mode. Low power mode is only
typo: hierarchy

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm (right):

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm:75: const NSRect&
toolbar_frame,
Is it alright if "Hide Toolbar in Full Screen" triggers it?

[ccameron, 2016-05-20 00:33:23]

Thanks -- updated.

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h (right):

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h:60: // Set if the
NSView heirarchy allows low power mode. Low power mode is only
On 2016/05/20 00:22:24, spqchan wrote:
> typo: hierarchy

Done.

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm (right):

https://codereview.chromium.org/1990163003/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm:75: const NSRect&
toolbar_frame,
On 2016/05/20 00:22:24, spqchan wrote:
> Is it alright if "Hide Toolbar in Full Screen" triggers it?

Yes. This actually allows triggering fullscreen low power mode when "Hide
Toolbar in Full Screen" and watching a video on a black background (it was
easier to allow it to work than to disallow it).

[spqchan, 2016-05-20 00:40:30]

lgtm

[ccameron, 2016-05-20 17:58:00]

Thanks!

[ccameron, 2016-05-20 17:58:05]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-05-20 17:58:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990163003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990163003/60001

[commit-bot: I haz the power, 2016-05-20 18:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 18:51:50]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-05-20 19:00:08]

On 2016/05/20 18:51:50, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Whoops, need a nil check.

[ccameron, 2016-05-20 19:50:52]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-05-20 19:50:52]

The patchset sent to the CQ was uploaded after l-g-t-m from spqchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1990163003/#ps80001
(title: "Add null check")

[commit-bot: I haz the power, 2016-05-20 19:51:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990163003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990163003/80001

[commit-bot: I haz the power, 2016-05-20 21:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 21:03:48]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[ccameron, 2016-05-23 21:51:43]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-05-23 21:51:44]

The patchset sent to the CQ was uploaded after l-g-t-m from spqchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1990163003/#ps100001
(title: "Add nil check for tests")

[commit-bot: I haz the power, 2016-05-23 21:52:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1990163003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1990163003/100001

[commit-bot: I haz the power, 2016-05-23 23:20:38]

Description was changed from

==========
Mac fullscreen low power: Add layout interactions and flag

This instantiates the NSWindow used for fullscreen low power mode, by
creating a FullscreenLowPowerCoordinator when entering fullscreen mode,
and adding it to the fullscreen transition group.

This also adds logic for determining if the layout of the browser chrome
is on-screen, and prevents moving the fullscreen low power window
in front if it is present.

Add a flag to enable this feature during development.

BUG=594460
==========

to

==========
Mac fullscreen low power: Add layout interactions and flag

This instantiates the NSWindow used for fullscreen low power mode, by
creating a FullscreenLowPowerCoordinator when entering fullscreen mode,
and adding it to the fullscreen transition group.

This also adds logic for determining if the layout of the browser chrome
is on-screen, and prevents moving the fullscreen low power window
in front if it is present.

Add a flag to enable this feature during development.

BUG=594460
==========

[commit-bot: I haz the power, 2016-05-23 23:20:39]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-23 23:21:57]

Description was changed from

==========
Mac fullscreen low power: Add layout interactions and flag

This instantiates the NSWindow used for fullscreen low power mode, by
creating a FullscreenLowPowerCoordinator when entering fullscreen mode,
and adding it to the fullscreen transition group.

This also adds logic for determining if the layout of the browser chrome
is on-screen, and prevents moving the fullscreen low power window
in front if it is present.

Add a flag to enable this feature during development.

BUG=594460
==========

to

==========
Mac fullscreen low power: Add layout interactions and flag

This instantiates the NSWindow used for fullscreen low power mode, by
creating a FullscreenLowPowerCoordinator when entering fullscreen mode,
and adding it to the fullscreen transition group.

This also adds logic for determining if the layout of the browser chrome
is on-screen, and prevents moving the fullscreen low power window
in front if it is present.

Add a flag to enable this feature during development.

BUG=594460

Committed: https://crrev.com/befa9c961bf06d34403d4f40cc469e1c774b829a
Cr-Commit-Position: refs/heads/master@{#395457}
==========

[commit-bot: I haz the power, 2016-05-23 23:21:58]

Patchset 6 (id:??) landed as
https://crrev.com/befa9c961bf06d34403d4f40cc469e1c774b829a
Cr-Commit-Position: refs/heads/master@{#395457}