Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2003173002: Represent lines using LayoutUnit in LineWidth (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
szager1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Represent lines using LayoutUnit in LineWidth Change LineWidth to represent m_availableWidth, m_left and m_right using LayoutUnits instead of floats. This matches the line box tree code as it uses LayoutUnits for line boxes. Further it solves a line breaking issue for floating elements due to a loss of precision when converting between LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor. This should allow the remaining use of LayoutUnit::epsilon to be removed as well but given the sensitive nature of this code I'd rather make that change in a separate and subsequent CL. R=szager@chromium.org BUG=609427 TEST=fast/sub-pixel/float-subpixel-wrapping.html Review-Url: https://codereview.chromium.org/1995103002 Cr-Commit-Position: refs/heads/master@{#394955} (cherry picked from commit 60bec7228df8e6114c75586ed3e3a45042b713eb) Committed: https://chromium.googlesource.com/chromium/src/+/65cba364286f30178fba4c25801604a7a8957e7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -28 lines) Patch
A third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/sub-pixel/float-subpixel-wrapping-expected.html View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.h View 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineWidth.cpp View 9 chunks +21 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eae
Committed patchset #1 (id:1) manually as 65cba364286f30178fba4c25801604a7a8957e7f.
4 years, 7 months ago (2016-05-23 20:54:11 UTC) #2
szager1
4 years, 7 months ago (2016-05-23 20:58:51 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698