Represent lines using LayoutUnit in LineWidth

Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

R=szager@chromium.org
BUG=609427
TEST=fast/sub-pixel/float-subpixel-wrapping.html

Committed: https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb
Cr-Commit-Position: refs/heads/master@{#394955}

[eae, 2016-05-19 19:24:40]

Description was changed from

==========
Change availableWidth to LayoutUnit in LineWidth


BUG=
==========

to

==========
Change availableWidth to LayoutUnit in LineWidth


BUG=609427
==========

[eae, 2016-05-19 20:48:13]

Description was changed from

==========
Change availableWidth to LayoutUnit in LineWidth


BUG=609427
==========

to

==========
Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

BUG=609427
==========

[eae, 2016-05-19 21:04:18]

Description was changed from

==========
Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

BUG=609427
==========

to

==========
Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

R=szager@chromium.org
BUG=609427
TEST=fast/sub-pixel/float-subpixel-wrapping.html
==========

[eae, 2016-05-19 21:04:18]

eae@chromium.org changed reviewers:
+ szager@chromium.org

[szager1, 2016-05-19 21:52:20]

lgtm

[szager1, 2016-05-19 21:52:25]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2016-05-19 21:53:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995103002/20001

[commit-bot: I haz the power, 2016-05-20 01:39:16]

Description was changed from

==========
Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

R=szager@chromium.org
BUG=609427
TEST=fast/sub-pixel/float-subpixel-wrapping.html
==========

to

==========
Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

R=szager@chromium.org
BUG=609427
TEST=fast/sub-pixel/float-subpixel-wrapping.html
==========

[commit-bot: I haz the power, 2016-05-20 01:39:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-20 01:41:53]

Description was changed from

==========
Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

R=szager@chromium.org
BUG=609427
TEST=fast/sub-pixel/float-subpixel-wrapping.html
==========

to

==========
Represent lines using LayoutUnit in LineWidth

Change LineWidth to represent m_availableWidth, m_left and m_right using
LayoutUnits instead of floats. This matches the line box tree code as it
uses LayoutUnits for line boxes. Further it solves a line breaking issue
for floating elements due to a loss of precision when converting between
LayoutUnits and floats, even without a LayoutUnit::epsilon fudge factor.

This should allow the remaining use of LayoutUnit::epsilon to be removed
as well but given the sensitive nature of this code I'd rather make that
change in a separate and subsequent CL.

R=szager@chromium.org
BUG=609427
TEST=fast/sub-pixel/float-subpixel-wrapping.html

Committed: https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb
Cr-Commit-Position: refs/heads/master@{#394955}
==========

[commit-bot: I haz the power, 2016-05-20 01:41:54]

Patchset 2 (id:??) landed as
https://crrev.com/60bec7228df8e6114c75586ed3e3a45042b713eb
Cr-Commit-Position: refs/heads/master@{#394955}