third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp - Issue 2003033004: Split custom element script use and move it into bindings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

Issue 2003033004: Split custom element script use and move it into bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing CORE_EXPORT header. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h ('K') | « third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

index c5f51b296e400e2105f02c3f1e150927966473ed..b350f6450cc9d7e18094b0a34a0cc9ac3925e5cb 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

@@ -132,7 +132,7 @@ bool V8V0CustomElementLifecycleCallbacks::setBinding(PassOwnPtr<V0CustomElementB

// The context is responsible for keeping the prototype

// alive. This in turn keeps callbacks alive through hidden

// references; see CALLBACK_LIST(SET_HIDDEN_VALUE).

- perContextData->addCustomElementBinding(std::move(binding));

+ perContextData->customElements()->v0AddBinding(std::move(binding));

return true;

}