Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2003023002: Introduce the Blink NotificationService, move permission checks there (Closed)

Created:
4 years, 7 months ago by Peter Beverloo
Modified:
4 years, 6 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dglazkov+blink, blink-reviews, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce the Blink NotificationService, move permission checks there This introduces the Mojo NotificationService in Blink and moves permission checks over from the IPC code-path to the Mojo code-path. This CL is a re-land of the original CL that was reverted because of crash reports: https://codereview.chromium.org/1948223004/. In addition, it removes usage of WeakPtr as pointed out by yszhen@. TBR=esprehn, jam, dcheng, mvanouwerkerk, haraken BUG=595685 Committed: https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd Cr-Commit-Position: refs/heads/master@{#397701}

Patch Set 1 #

Patch Set 2 : Don't rely on WeakPtr (yzshen@ comments) #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+380 lines, -59 lines) Patch
M content/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/browser/notifications/blink_notification_service_impl.h View 1 chunk +53 lines, -0 lines 0 comments Download
A content/browser/notifications/blink_notification_service_impl.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M content/browser/notifications/notification_message_filter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/notifications/platform_notification_context_impl.h View 1 6 chunks +23 lines, -1 line 0 comments Download
M content/browser/notifications/platform_notification_context_impl.cc View 1 2 2 chunks +37 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M content/child/notifications/notification_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M content/common/platform_notification_messages.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/mojo/blink_service_registry_impl.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/mojo/blink_service_registry_impl.cc View 1 chunk +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.cpp View 1 2 4 chunks +4 lines, -10 lines 0 comments Download
A third_party/WebKit/Source/modules/notifications/NotificationManager.h View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/notifications/NotificationManager.cpp View 1 chunk +67 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/blink.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/notifications/OWNERS View 1 chunk +15 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h View 2 chunks +0 lines, -9 lines 0 comments Download
A third_party/WebKit/public/platform/modules/notifications/notification_service.mojom View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Peter Beverloo
TBR the original reviewers. This CL is identical to the one that landed (albeit rebased), ...
4 years, 6 months ago (2016-06-03 13:28:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003023002/40001
4 years, 6 months ago (2016-06-03 13:28:33 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-03 14:09:39 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f28cb7f78b2f5df0d02ccdfa430edf5e304dfcdd Cr-Commit-Position: refs/heads/master@{#397701}
4 years, 6 months ago (2016-06-03 14:11:50 UTC) #9
haraken
4 years, 6 months ago (2016-06-03 14:15:08 UTC) #10
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698