content/browser/notifications/notification_message_filter.cc - Issue 2003023002: Introduce the Blink NotificationService, move permission checks there

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_message_filter.cc

Issue 2003023002: Introduce the Blink NotificationService, move permission checks there (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_message_filter.h ('k') | content/browser/notifications/platform_notification_context_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_message_filter.cc

diff --git a/content/browser/notifications/notification_message_filter.cc b/content/browser/notifications/notification_message_filter.cc

index 876a89c11e185cb0371b6a4d74294b913f108b19..d522e75f7d54a3c98f5fc561aad7f0828ab5368a 100644

--- a/content/browser/notifications/notification_message_filter.cc

+++ b/content/browser/notifications/notification_message_filter.cc

@@ -95,8 +95,6 @@ void NotificationMessageFilter::OnDestruct() const {

bool NotificationMessageFilter::OnMessageReceived(const IPC::Message& message) {

bool handled = true;

IPC_BEGIN_MESSAGE_MAP(NotificationMessageFilter, message)

- IPC_MESSAGE_HANDLER(PlatformNotificationHostMsg_CheckPermission,

- OnCheckNotificationPermission)

IPC_MESSAGE_HANDLER(PlatformNotificationHostMsg_Show,

OnShowPlatformNotification)

IPC_MESSAGE_HANDLER(PlatformNotificationHostMsg_ShowPersistent,

@@ -121,14 +119,6 @@ void NotificationMessageFilter::OverrideThreadForMessage(

*thread = BrowserThread::UI;

}

-void NotificationMessageFilter::OnCheckNotificationPermission(

- const GURL& origin,

- blink::mojom::PermissionStatus* permission_status) {

- DCHECK_CURRENTLY_ON(BrowserThread::IO);

- *permission_status = GetPermissionForOriginOnIO(origin);

void NotificationMessageFilter::OnShowPlatformNotification(

int notification_id,

const GURL& origin,