Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(330)

Issue 20030: Autocomplete popup uses its own style (Closed)

Created:
10 years, 6 months ago by jcampan
Modified:
8 years, 3 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

The autocomplete popup menu was using the style of the edit field it is associated with. This is wrong, its font should be independent of the edit field. TEST=Open a page with a form that has an input field that uses a huge font. Bring up the autocomplete popup, the items should use a normal size font. BUG=7372, 6326 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9153

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M webkit/glue/webview_impl.cc View 1 4 chunks +16 lines, -6 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
jcampan
10 years, 6 months ago (2009-02-04 00:44:07 UTC) #1
ojan
10 years, 6 months ago (2009-02-04 02:12:47 UTC) #2
One nit. Otherwise, LGTM

http://codereview.chromium.org/20030/diff/1003/1004
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/20030/diff/1003/1004#newcode144
Line 144: font_description.setComputedSize(12.0);
Please add a TODO to make sure that this works well when the system font is
large (i.e. that this gets large).

Powered by Google App Engine
This is Rietveld 408576698