Issue 20030: Autocomplete popup uses its own style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20030: Autocomplete popup uses its own style (Closed)

Created:
11 years, 10 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The autocomplete popup menu was using the style of the edit field it is associated with. This is wrong, its font should be independent of the edit field. TEST=Open a page with a form that has an input field that uses a huge font. Bring up the autocomplete popup, the items should use a normal size font. BUG=7372, 6326 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9153

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -6 lines)			Patch
	M	webkit/glue/webview_impl.cc	View	1	4 chunks	+16 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ojan

11 years, 10 months ago (2009-02-04 02:12:47 UTC) #2

One nit. Otherwise, LGTM

http://codereview.chromium.org/20030/diff/1003/1004
File webkit/glue/webview_impl.cc (right):

http://codereview.chromium.org/20030/diff/1003/1004#newcode144
Line 144: font_description.setComputedSize(12.0);
Please add a TODO to make sure that this works well when the system font is
large (i.e. that this gets large).

Expand Messages | Collapse Messages