Autocomplete popup uses its own style

webkit/glue/webview_impl.cc

 /*
 * Copyright 2007 Google Inc. All Rights Reserved.
 *
 * Portions Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
 *
 * ***** BEGIN LICENSE BLOCK *****
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
@@ skipping 18 matching lines @@
 * ***** END LICENSE BLOCK *****
 *
 */
 
 #include "config.h"
 #include "build/build_config.h"
 
 #include "base/compiler_specific.h"
 MSVC_PUSH_WARNING_LEVEL(0);
 #include "CSSStyleSelector.h"
+#include "CSSValueKeywords.h"
 #include "Cursor.h"
 #include "Document.h"
 #include "DocumentLoader.h"
 #include "DragController.h"
 #include "DragData.h"
 #include "Editor.h"
 #include "EventHandler.h"
 #include "FocusController.h"
 #include "FontDescription.h"
 #include "FrameLoader.h"
@@ skipping 76 matching lines @@
     : public RefCounted<AutocompletePopupMenuClient>,
       public WebCore::PopupMenuClient {
  public:
   AutocompletePopupMenuClient(WebViewImpl* webview,
                               WebCore::HTMLInputElement* text_field,
                               const std::vector<std::wstring>& suggestions,
                               int default_suggestion_index)
       : text_field_(text_field),
         selected_index_(default_suggestion_index),
         webview_(webview) {
+    FontDescription font_description;
+#if defined(OS_WIN)
+    theme()->systemFont(CSSValueWebkitControl, text_field->document(),
+                        font_description);
+#else
+    NOTIMPLEMENTED();
+#endif
+    // Use a smaller font size to match IE/Firefox.
+    font_description.setComputedSize(12.0);

[ojan, 2009/02/04 02:12:47]

Please add a TODO to make sure that this works well when the system font is
large (i.e. that this gets large).

+    Font font(font_description, 0, 0);
+    font.update(text_field->document()->styleSelector()->fontSelector());
+    style_.reset(new PopupMenuStyle(Color::black, Color::white, font, true));
     SetSuggestions(suggestions);
   }
   virtual ~AutocompletePopupMenuClient() {
   }
 
   virtual void valueChanged(unsigned listIndex, bool fireEvents = true) {
     text_field_->setValue(suggestions_[listIndex]);
   }  
 
   virtual WebCore::String itemText(unsigned list_index) const {
     return suggestions_[list_index];
   }
   
   virtual bool itemIsEnabled(unsigned listIndex) const {
     return true;
   }
 
   virtual PopupMenuStyle itemStyle(unsigned listIndex) const {
-    return menuStyle();
+    return *style_;
   }
 
   virtual PopupMenuStyle menuStyle() const {
-    RenderStyle* style = text_field_->renderStyle() ?
-                            text_field_->renderStyle() :
-                            text_field_->computedStyle();
-    return PopupMenuStyle(style->color(), Color::white, style->font(),
-                          style->visibility() == VISIBLE);
+    return *style_;
   }
 
   virtual int clientInsetLeft() const {
     return 0;
   }
   virtual int clientInsetRight() const {
     return 0;
   }
   virtual int clientPaddingLeft() const {
 #if defined(OS_WIN)
@@ skipping 71 matching lines @@
 
   WebCore::HTMLInputElement* text_field() const {
     return text_field_.get();
   }
 
  private:
   RefPtr<WebCore::HTMLInputElement> text_field_;
   std::vector<WebCore::String> suggestions_;
   int selected_index_;
   WebViewImpl* webview_;
+  scoped_ptr<PopupMenuStyle> style_;
 };
 
 // WebView ----------------------------------------------------------------
 
 /*static*/
 WebView* WebView::Create(WebViewDelegate* delegate,
                          const WebPreferences& prefs) {
   WebViewImpl* instance = new WebViewImpl();
   instance->AddRef();
   instance->SetPreferences(prefs);
@@ skipping 1365 matching lines @@
   Frame* frame = page_->focusController()->focusedFrame();
   if (!frame)
     return NULL;
 
   Document* document = frame->document();
   if (!document)
     return NULL;
 
   return document->focusedNode();
 }