chrome/test/ppapi/ppapi_browsertest.cc - Issue 200283002: Fix the crash for the AudioShared.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/ppapi/ppapi_browsertest.cc

Issue 200283002: Fix the crash for the AudioShared. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@open_resource3

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/ppapi/ppapi_browsertest.cc

diff --git a/chrome/test/ppapi/ppapi_browsertest.cc b/chrome/test/ppapi/ppapi_browsertest.cc

index 8d4c3752c53b18cfcca4598ab0eee83bf52a0d3e..39e845ff4c3c786eee1a8fe55e5003a743b50d7c 100644

--- a/chrome/test/ppapi/ppapi_browsertest.cc

+++ b/chrome/test/ppapi/ppapi_browsertest.cc

@@ -1198,7 +1198,8 @@ IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClTest, AudioThreadCreator) {

}

// TODO(hidehiko): Enable AudioThreadCreator testing for NonSfi when

Mark Seaborn 2014/04/23 02:28:40 You can remove the TODO now.

hidehiko 2014/04/23 13:32:59 Done.

// PPB_Audio_Shared::SetThreadFunctions is fixed.

-IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClNonSfiTest, DISABLED_AudioThreadCreator) {

+IN_PROC_BROWSER_TEST_F(PPAPINaClPNaClNonSfiTest,

+ MAYBE_NONSFI(AudioThreadCreator)) {

RUN_AUDIO_THREAD_CREATOR_SUBTESTS;

}

« no previous file with comments | « no previous file | ppapi/nacl_irt/plugin_main.cc » ('j') | ppapi/shared_impl/ppb_audio_shared.cc » ('J')