Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/api/web_request/web_request_event_details.h

Issue 2002763003: webRequest: reliably determine tabId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webRequest-testing-unload
Patch Set: Use FrameData + fix comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/web_request/web_request_api.cc ('k') | extensions/browser/api/web_request/web_request_event_details.cc » ('j') | extensions/browser/api/web_request/web_request_event_details.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/web_request/web_request_event_details.h
diff --git a/extensions/browser/api/web_request/web_request_event_details.h b/extensions/browser/api/web_request/web_request_event_details.h
index bd9c995a15b34e4e7ce1e8c87f479a227f5945c9..7ab2ed719f2b52263580fed9dcf08650d983e2b9 100644
--- a/extensions/browser/api/web_request/web_request_event_details.h
+++ b/extensions/browser/api/web_request/web_request_event_details.h
@@ -89,12 +89,14 @@ class WebRequestEventDetails {
}
// Sets the following keys using information from constructor.
+ // - tabId
// - frameId
// - parentFrameId
// This must be called from the UI thread.
void DetermineFrameIdOnUI();
// Sets the following keys using information from constructor.
+ // - tabId
// - frameId
// - parentFrameId
//
« no previous file with comments | « extensions/browser/api/web_request/web_request_api.cc ('k') | extensions/browser/api/web_request/web_request_event_details.cc » ('j') | extensions/browser/api/web_request/web_request_event_details.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698