extensions/browser/api/web_request/web_request_api.cc - Issue 2002763003: webRequest: reliably determine tabId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 2002763003: webRequest: reliably determine tabId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webRequest-testing-unload

Patch Set: Use FrameData + fix comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | extensions/browser/api/web_request/web_request_event_details.h » ('j') | extensions/browser/api/web_request/web_request_event_details.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/web_request_api.cc

diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc

index e60c50c3a3f787ddc1b20802c3746eb90d0ad2a4..17c1a1d6519077aa9f9f14cca85e4577de9261d7 100644

--- a/extensions/browser/api/web_request/web_request_api.cc

+++ b/extensions/browser/api/web_request/web_request_api.cc

@@ -601,17 +601,6 @@ ExtensionWebRequestEventRouter::CreateEventDetails(

std::unique_ptr<WebRequestEventDetails> event_details(

new WebRequestEventDetails(request, extra_info_spec));

- int render_frame_id = -1;

- int render_process_id = -1;

- int tab_id = -1;

- ExtensionApiFrameIdMap::FrameData frame_data;

- if (content::ResourceRequestInfo::GetRenderFrameForRequest(

- request, &render_process_id, &render_frame_id) &&

- ExtensionApiFrameIdMap::Get()->GetCachedFrameDataOnIO(

- render_process_id, render_frame_id, &frame_data)) {

- tab_id = frame_data.tab_id;

- }

- event_details->SetInteger(keys::kTabIdKey, tab_id);

return event_details;

}