Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: xfa/fwl/theme/cfwl_scrollbartp.cpp

Issue 2002643003: Fix a bug on scrollbar's checking theme states (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fwl/theme/cfwl_scrollbartp.cpp
diff --git a/xfa/fwl/theme/cfwl_scrollbartp.cpp b/xfa/fwl/theme/cfwl_scrollbartp.cpp
index 54dfbe5531cf09fa247d3d3ba4f8e8ec2031bf7a..79d0ce72f9202c8787fc648971addcc7f4a62f41 100644
--- a/xfa/fwl/theme/cfwl_scrollbartp.cpp
+++ b/xfa/fwl/theme/cfwl_scrollbartp.cpp
@@ -51,7 +51,9 @@ FX_BOOL CFWL_ScrollBarTP::DrawBackground(CFWL_ThemeBackground* pParams) {
return FALSE;
IFWL_Widget* pWidget = pParams->m_pWidget;
FWLTHEME_STATE eState = FWLTHEME_STATE_Normal;
- switch (pParams->m_dwStates & 0x03) {
+ switch (pParams->m_dwStates &
Tom Sepez 2016/05/20 20:14:10 Switching on flags seems wrong, what if two or mor
Wei Li 2016/05/20 20:54:31 Done.
+ (CFWL_PartState_Hovered | CFWL_PartState_Pressed |
+ CFWL_PartState_Disabled)) {
case CFWL_PartState_Hovered: {
eState = FWLTHEME_STATE_Hover;
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698