Fix a bug on scrollbar's checking theme states

xfa/fwl/theme/cfwl_scrollbartp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/theme/cfwl_scrollbartp.h"
 
 #include "xfa/fwl/basewidget/ifwl_scrollbar.h"
 #include "xfa/fwl/core/cfwl_themebackground.h"
@@ skipping 33 matching lines @@
   if (m_pThemeData) {
     SetThemeData(FWL_GetThemeColor(dwThemeID));
   }
   return CFWL_WidgetTP::SetThemeID(pWidget, dwThemeID, bChildren);
 }
 FX_BOOL CFWL_ScrollBarTP::DrawBackground(CFWL_ThemeBackground* pParams) {
   if (!pParams)
     return FALSE;
   IFWL_Widget* pWidget = pParams->m_pWidget;
   FWLTHEME_STATE eState = FWLTHEME_STATE_Normal;
-  switch (pParams->m_dwStates & 0x03) {
+  switch (pParams->m_dwStates &

[Tom Sepez, 2016/05/20 20:14:10]

Switching on flags seems wrong, what if two or more are set?

prefer if (x & a) {} else if (x & b) {} else if (x & c) {}.

[Wei Li, 2016/05/20 20:54:31]

Done.

+          (CFWL_PartState_Hovered | CFWL_PartState_Pressed |
+           CFWL_PartState_Disabled)) {
     case CFWL_PartState_Hovered: {
       eState = FWLTHEME_STATE_Hover;
       break;
     }
     case CFWL_PartState_Pressed: {
       eState = FWLTHEME_STATE_Pressed;
       break;
     }
     case CFWL_PartState_Disabled: {
       eState = FWLTHEME_STATE_Disabale;
@@ skipping 239 matching lines @@
     m_pThemeData->clrBtnBorder[1] = ArgbEncode(0xff, 218, 230, 254);
     m_pThemeData->clrPawColorLight[2] = ArgbEncode(0xff, 207, 221, 253);
     m_pThemeData->clrPawColorDark[2] = ArgbEncode(0xff, 131, 158, 216);
     m_pThemeData->clrBtnBK[2][0] = ArgbEncode(0xff, 167, 190, 245);
     m_pThemeData->clrBtnBK[2][1] = ArgbEncode(0xff, 146, 179, 249);
     m_pThemeData->clrBtnBorder[2] = ArgbEncode(0xff, 124, 159, 211);
     m_pThemeData->clrTrackBKStart = ArgbEncode(0xff, 243, 241, 236);
     m_pThemeData->clrTrackBKEnd = ArgbEncode(0xff, 254, 254, 251);
   }
 }