Fix a bug on scrollbar's checking theme states

Fix a bug on scrollbar's checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.

BUG=613623, 427616
Committed: https://pdfium.googlesource.com/pdfium/+/dc3ccdfb49c4d533d524d2084a7ebe5117f35934

[Wei Li, 2016-05-20 19:45:19]

Description was changed from

==========
Fix a bug on scrollbar checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.
==========

to

==========
Fix a bug on scrollbar's checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.
==========

[Wei Li, 2016-05-20 19:47:24]

weili@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Wei Li, 2016-05-20 19:47:25]

for review, thanks

[Tom Sepez, 2016-05-20 20:14:10]

https://codereview.chromium.org/2002643003/diff/1/xfa/fwl/theme/cfwl_scrollba...
File xfa/fwl/theme/cfwl_scrollbartp.cpp (right):

https://codereview.chromium.org/2002643003/diff/1/xfa/fwl/theme/cfwl_scrollba...
xfa/fwl/theme/cfwl_scrollbartp.cpp:54: switch (pParams->m_dwStates &
Switching on flags seems wrong, what if two or more are set?

prefer if (x & a) {} else if (x & b) {} else if (x & c) {}.

[Wei Li, 2016-05-20 20:54:31]

thanks

https://codereview.chromium.org/2002643003/diff/1/xfa/fwl/theme/cfwl_scrollba...
File xfa/fwl/theme/cfwl_scrollbartp.cpp (right):

https://codereview.chromium.org/2002643003/diff/1/xfa/fwl/theme/cfwl_scrollba...
xfa/fwl/theme/cfwl_scrollbartp.cpp:54: switch (pParams->m_dwStates &
On 2016/05/20 20:14:10, Tom Sepez wrote:
> Switching on flags seems wrong, what if two or more are set?
> 
> prefer if (x & a) {} else if (x & b) {} else if (x & c) {}.

Done.

[Tom Sepez, 2016-05-20 20:57:29]

lgtm

[Wei Li, 2016-05-20 21:29:27]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-05-20 21:29:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002643003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002643003/20001

[Tom Sepez, 2016-05-20 21:56:33]

Description was changed from

==========
Fix a bug on scrollbar's checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.
==========

to

==========
Fix a bug on scrollbar's checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.

BUG=613623
==========

[Tom Sepez, 2016-05-20 21:57:02]

Description was changed from

==========
Fix a bug on scrollbar's checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.

BUG=613623
==========

to

==========
Fix a bug on scrollbar's checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.

BUG=613623, 427616
==========

[commit-bot: I haz the power, 2016-05-20 22:16:21]

Description was changed from

==========
Fix a bug on scrollbar's checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.

BUG=613623, 427616
==========

to

==========
Fix a bug on scrollbar's checking theme states

The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.

BUG=613623, 427616

Committed:
https://pdfium.googlesource.com/pdfium/+/dc3ccdfb49c4d533d524d2084a7ebe5117f3...
==========

[commit-bot: I haz the power, 2016-05-20 22:16:22]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/dc3ccdfb49c4d533d524d2084a7ebe5117f3...