runtime/vm/jit_optimizer.cc - Issue 2002583002: Background compiler should validate CHA decisions before committing the code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/jit_optimizer.cc

Issue 2002583002: Background compiler should validate CHA decisions before committing the code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/jit_optimizer.cc

diff --git a/runtime/vm/jit_optimizer.cc b/runtime/vm/jit_optimizer.cc

index f4d875764247d3588c74141c0ec99e527712da83..172f5d241645708f30d10b589c1c408f759a8971 100644

--- a/runtime/vm/jit_optimizer.cc

+++ b/runtime/vm/jit_optimizer.cc

@@ -2391,7 +2391,7 @@ bool JitOptimizer::TypeCheckAsClassEquality(const AbstractType& type) {

type_class.ToCString());

}

if (FLAG_use_cha_deopt) {

- thread()->cha()->AddToLeafClasses(type_class);

+ thread()->cha()->AddToGuardedClasses(type_class, /*subclass_count=*/0);

}

} else {

return false;

« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | no next file » | no next file with comments »