Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 2002583002: Background compiler should validate CHA decisions before committing the code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/jit_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc
index af0a03fcd42e3eb46970811120a75ab8a6a9dd7d..1138c6a20c562577a773ce53cb6d3d58371f792e 100644
--- a/runtime/vm/flow_graph_type_propagator.cc
+++ b/runtime/vm/flow_graph_type_propagator.cc
@@ -504,7 +504,7 @@ intptr_t CompileType::ToNullableCid() {
type_class.ToCString());
}
if (FLAG_use_cha_deopt) {
- cha->AddToLeafClasses(type_class);
+ cha->AddToGuardedClasses(type_class, /*subclass_count=*/0);
}
cid_ = type_class.id();
} else {
@@ -752,7 +752,8 @@ CompileType ParameterInstr::ComputeType() const {
type_class.ToCString());
}
if (FLAG_use_cha_deopt) {
- thread->cha()->AddToLeafClasses(type_class);
+ thread->cha()->AddToGuardedClasses(
+ type_class, /*subclass_count=*/0);
}
cid = type_class.id();
}
« no previous file with comments | « runtime/vm/flow_graph.cc ('k') | runtime/vm/jit_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698