Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2002513002: In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
Reviewers:
tkent, Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't check for all-pass baseline files in platform and virtual. BUG=613387 Committed: https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8 Cr-Commit-Position: refs/heads/master@{#395370}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Respond to feedback 1 (s/expected.txt/-expected.txt, check path for LayoutTests) #

Patch Set 3 : Fix two other mistakes: skip deleted files, add return statement #

Total comments: 2

Patch Set 4 : Fix path and expand comment for virtual test baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/PRESUBMIT.py View 1 2 3 2 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
qyearsley
Hi Kent, whey do we want to not check these files in virtual?
4 years, 7 months ago (2016-05-20 04:54:12 UTC) #2
tkent
https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTests/PRESUBMIT.py File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTests/PRESUBMIT.py#newcode42 third_party/WebKit/LayoutTests/PRESUBMIT.py:42: if not path.endswith('expected.txt'): expected.txt -> -expected.txt https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTests/PRESUBMIT.py#newcode45 third_party/WebKit/LayoutTests/PRESUBMIT.py:45: if ...
4 years, 7 months ago (2016-05-20 05:14:25 UTC) #3
qyearsley
https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTests/PRESUBMIT.py File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTests/PRESUBMIT.py#newcode42 third_party/WebKit/LayoutTests/PRESUBMIT.py:42: if not path.endswith('expected.txt'): On 2016/05/20 at 05:14:25, tkent wrote: ...
4 years, 7 months ago (2016-05-20 17:14:18 UTC) #4
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-20 19:38:45 UTC) #6
tkent
lgtm https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTests/PRESUBMIT.py File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTests/PRESUBMIT.py#newcode48 third_party/WebKit/LayoutTests/PRESUBMIT.py:48: # more general baseline. On 2016/05/20 at 17:14:18, ...
4 years, 7 months ago (2016-05-22 23:30:38 UTC) #7
qyearsley
https://codereview.chromium.org/2002513002/diff/40001/third_party/WebKit/LayoutTests/PRESUBMIT.py File third_party/WebKit/LayoutTests/PRESUBMIT.py (right): https://codereview.chromium.org/2002513002/diff/40001/third_party/WebKit/LayoutTests/PRESUBMIT.py#newcode47 third_party/WebKit/LayoutTests/PRESUBMIT.py:47: input_api.os_path.join('Layout', 'virtual') in path): On 2016/05/22 at 23:30:38, tkent ...
4 years, 7 months ago (2016-05-23 17:31:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002513002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002513002/60001
4 years, 7 months ago (2016-05-23 17:32:27 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-23 18:35:35 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8 Cr-Commit-Position: refs/heads/master@{#395370}
4 years, 7 months ago (2016-05-23 18:38:58 UTC) #14
caseq
4 years, 7 months ago (2016-05-23 22:22:37 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2008753002/ by caseq@chromium.org.

The reason for reverting is: This broke presubmit on layout tests with:
NameError: global name 'expected_files' is not defined.

Powered by Google App Engine
This is Rietveld 408576698