In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual.

Don't check for all-pass baseline files in platform and virtual.

BUG=613387
Committed: https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8
Cr-Commit-Position: refs/heads/master@{#395370}

[qyearsley, 2016-05-20 04:53:28]

qyearsley@chromium.org changed reviewers:
+ tkent@chromium.org

[qyearsley, 2016-05-20 04:54:12]

Hi Kent, whey do we want to not check these files in virtual?

[tkent, 2016-05-20 05:14:25]

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/PRESUBMIT.py (right):

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/PRESUBMIT.py:42: if not
path.endswith('expected.txt'):
expected.txt -> -expected.txt

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/PRESUBMIT.py:45: if 'platform' in path_parts or
'virtual' in path_parts:
Please check 'LayoutTests' followed by 'platform', or 'LayoutTests' followed by
'virtual'.

This code matches imported/web-platform-tests/html/editing/dnd/platform/
unexpectedly.

[qyearsley, 2016-05-20 17:14:18]

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/PRESUBMIT.py (right):

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/PRESUBMIT.py:42: if not
path.endswith('expected.txt'):
On 2016/05/20 at 05:14:25, tkent wrote:
> expected.txt -> -expected.txt

Done; good catch

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/PRESUBMIT.py:45: if 'platform' in path_parts or
'virtual' in path_parts:
On 2016/05/20 at 05:14:25, tkent wrote:
> Please check 'LayoutTests' followed by 'platform', or 'LayoutTests' followed
by 'virtual'.
> 
> This code matches imported/web-platform-tests/html/editing/dnd/platform/
unexpectedly.

Now changed to check `input_api.os_path.join('LayoutTests', 'platform') in
path`; does that seem OK?

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/PRESUBMIT.py:48: # more general baseline.
I'd like to add a comment here about why we should ignore files in
LayoutTests/virtual; is it also related to baseline fallbacks? If there's a
missing -expected.txt file for a virtual layout test does the test runner fall
back to the non-virtual corresponding test baseline?

[Dirk Pranke, 2016-05-20 19:38:44]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-05-20 19:38:45]

lgtm

[tkent, 2016-05-22 23:30:38]

lgtm

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/PRESUBMIT.py (right):

https://codereview.chromium.org/2002513002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/PRESUBMIT.py:48: # more general baseline.
On 2016/05/20 at 17:14:18, qyearsley wrote:
> I'd like to add a comment here about why we should ignore files in
LayoutTests/virtual; is it also related to baseline fallbacks? If there's a
missing -expected.txt file for a virtual layout test does the test runner fall
back to the non-virtual corresponding test baseline?

Right.

https://codereview.chromium.org/2002513002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/PRESUBMIT.py (right):

https://codereview.chromium.org/2002513002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/PRESUBMIT.py:47: input_api.os_path.join('Layout',
'virtual') in path):
Layout -> LayoutTests

[qyearsley, 2016-05-23 17:31:36]

https://codereview.chromium.org/2002513002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/PRESUBMIT.py (right):

https://codereview.chromium.org/2002513002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/PRESUBMIT.py:47: input_api.os_path.join('Layout',
'virtual') in path):
On 2016/05/22 at 23:30:38, tkent wrote:
> Layout -> LayoutTests

Fixed

[qyearsley, 2016-05-23 17:31:43]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-05-23 17:31:44]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2002513002/#ps60001
(title: "Fix path and expand comment for virtual test baselines")

[commit-bot: I haz the power, 2016-05-23 17:32:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2002513002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2002513002/60001

[commit-bot: I haz the power, 2016-05-23 18:35:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-23 18:38:57]

Description was changed from

==========
Don't check for all-pass baseline files in platform and virtual.

BUG=613387
==========

to

==========
Don't check for all-pass baseline files in platform and virtual.

BUG=613387

Committed: https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8
Cr-Commit-Position: refs/heads/master@{#395370}
==========

[commit-bot: I haz the power, 2016-05-23 18:38:58]

Patchset 4 (id:??) landed as
https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8
Cr-Commit-Position: refs/heads/master@{#395370}

[caseq, 2016-05-23 22:22:37]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2008753002/ by caseq@chromium.org.

The reason for reverting is: This broke presubmit on layout tests with:
NameError: global name 'expected_files' is not defined.