In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual.

third_party/WebKit/LayoutTests/PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """LayoutTests/ presubmit script for Blink.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
 import filecmp
 
 
 def _CheckTestharnessResults(input_api, output_api):
-    expected_files = [f.AbsoluteLocalPath() for f in input_api.AffectedFiles() if f.LocalPath().endswith('-expected.txt') and f.Action() != 'D']
-    if len(expected_files) == 0:
+    """Checks for testharness.js test baseline files that contain only PASS lines.
+
+    In general these files are unnecessary because for testharness.js tests, if there is
+    no baseline file then the test is considered to pass when the output is all PASS.
+    """
+    baseline_files = _TestharnessBaselineFilesToCheck(input_api)
+    if not baseline_files:
         return []
 
     checker_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
         '..', 'Tools', 'Scripts', 'check-testharness-expected-pass')
 
     args = [input_api.python_executable, checker_path]
     args.extend(expected_files)
     _, errs = input_api.subprocess.Popen(args,
         stdout=input_api.subprocess.PIPE,
         stderr=input_api.subprocess.PIPE).communicate()
     if errs:
         return [output_api.PresubmitError(errs)]
     return []
 
 
+def _TestharnessBaselineFilesToCheck(input_api):
+    """Returns a list of paths of -expected.txt files for testharness.js tests."""
+    baseline_files = []
+    for f in input_api.AffectedFiles():
+        path = f.AbsoluteLocalPath()
+        if not path.endswith('expected.txt'):

[tkent, 2016/05/20 05:14:25]

expected.txt -> -expected.txt

[qyearsley, 2016/05/20 17:14:18]

Done; good catch

+            continue
+        path_parts = path.split(os.sep)
+        if 'platform' in path_parts or 'virtual' in path_parts:

[tkent, 2016/05/20 05:14:25]

Please check 'LayoutTests' followed by 'platform', or 'LayoutTests' followed by
'virtual'.

This code matches imported/web-platform-tests/html/editing/dnd/platform/
unexpectedly.

[qyearsley, 2016/05/20 17:14:18]

Now changed to check `input_api.os_path.join('LayoutTests', 'platform') in
path`; does that seem OK?

+            # We want to ignore files in LayoutTests/platform, because some all-PASS
+            # platform specific baselines may be necessary to prevent fallback to a
+            # more general baseline.

[qyearsley, 2016/05/20 17:14:18]

I'd like to add a comment here about why we should ignore files in
LayoutTests/virtual; is it also related to baseline fallbacks? If there's a
missing -expected.txt file for a virtual layout test does the test runner fall
back to the non-virtual corresponding test baseline?

[tkent, 2016/05/22 23:30:37]

Right.

+            continue
+        baseline_files.append(path)
+
+
 def _CheckIdenticalFiles(input_api, output_api):
     """Verifies that certain files are identical in various locations.
     These files should always be updated together."""
 
     dirty_files = set(input_api.LocalPaths())
 
     groups = [[
         'imported/web-platform-tests/resources/testharness.js',
         'resources/testharness.js',
     ], [
@@ skipping 27 matching lines @@
     results.extend(_CheckTestharnessResults(input_api, output_api))
     results.extend(_CheckIdenticalFiles(input_api, output_api))
     return results
 
 
 def CheckChangeOnCommit(input_api, output_api):
     results = []
     results.extend(_CheckTestharnessResults(input_api, output_api))
     results.extend(_CheckIdenticalFiles(input_api, output_api))
     return results