third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp - Issue 2002383002: Avoid string allocation when parsing CSSPrimitiveValue::UnitType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp

Issue 2002383002: Avoid string allocation when parsing CSSPrimitiveValue::UnitType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp

index 8db5b554cf3789f958b7f35bc71ccc225b95557c..1acad1008d067fa35f056c3ad4e5308e5ea49169 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp

@@ -5,6 +5,7 @@

#include "core/css/cssom/CSSLengthValue.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "core/css/CSSPrimitiveValueUnitTrie.h"

#include "core/css/cssom/CSSSimpleLength.h"

#include "core/css/cssom/CalcDictionary.h"

#include "core/css/cssom/StyleCalcLength.h"

@@ -17,7 +18,9 @@ CSSPrimitiveValue::UnitType CSSLengthValue::unitFromName(const String& name)

if (equalIgnoringASCIICase(name, "percent") || name == "%") {

return CSSPrimitiveValue::UnitType::Percentage;

}

- return CSSPrimitiveValue::fromName(name);

+ if (name.is8Bit())

+ return lookupCSSPrimitiveValueUnit(name.characters8(), name.length());

+ return lookupCSSPrimitiveValueUnit(name.characters16(), name.length());

}

CSSLengthValue* CSSLengthValue::from(const String& cssString, ExceptionState& exceptionState)