third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp - Issue 2002383002: Avoid string allocation when parsing CSSPrimitiveValue::UnitType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp

Issue 2002383002: Avoid string allocation when parsing CSSPrimitiveValue::UnitType (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.in ('k') | third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp

index f9821b756decb871f272b27b45de444e8898a2a6..81865a397234f70d7e52e6154ba1d1ff38e847a7 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSAngleValue.cpp

@@ -6,13 +6,18 @@

#include "bindings/core/v8/ExceptionState.h"

#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSPrimitiveValueUnitTrie.h"

#include "wtf/MathExtras.h"

namespace blink {

CSSAngleValue* CSSAngleValue::create(double value, const String& unit, ExceptionState& exceptionState)

{

- CSSPrimitiveValue::UnitType primitiveUnit = CSSPrimitiveValue::fromName(unit);

+ CSSPrimitiveValue::UnitType primitiveUnit;

+ if (unit.is8Bit())

+ primitiveUnit = lookupCSSPrimitiveValueUnit(unit.characters8(), unit.length());

+ else

+ primitiveUnit = lookupCSSPrimitiveValueUnit(unit.characters16(), unit.length());

DCHECK(CSSPrimitiveValue::isAngle(primitiveUnit));

return new CSSAngleValue(value, primitiveUnit);

}