Chromium Code Reviews

Issue 2002353003: Don't short circuit visiting else (Closed)

Created:
4 years, 7 months ago by srawlins
Modified:
4 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't short circuit visiting else BUG=https://github.com/dart-lang/sdk/issues/26517 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/d948ea2c17fe7fe9d93ec18d7c2b4c907ee8271f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+7 lines, -1 line)
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +3 lines, -1 line 0 comments
M pkg/analyzer/test/generated/all_the_rest_test.dart View 1 chunk +4 lines, -0 lines 1 comment

Messages

Total messages: 6 (2 generated)
srawlins
4 years, 7 months ago (2016-05-24 01:22:35 UTC) #2
srawlins
https://codereview.chromium.org/2002353003/diff/1/pkg/analyzer/test/generated/all_the_rest_test.dart File pkg/analyzer/test/generated/all_the_rest_test.dart (right): https://codereview.chromium.org/2002353003/diff/1/pkg/analyzer/test/generated/all_the_rest_test.dart#newcode3534 pkg/analyzer/test/generated/all_the_rest_test.dart:3534: void test_forStatement_implicitTrue_if_break() { This test fails at HEAD.
4 years, 7 months ago (2016-05-24 01:23:05 UTC) #3
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-24 13:47:46 UTC) #4
srawlins
4 years, 7 months ago (2016-05-24 13:54:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d948ea2c17fe7fe9d93ec18d7c2b4c907ee8271f (presubmit successful).

Powered by Google App Engine